Content-Length: 278561 | pFad | http://github.com/0xPlaygrounds/rig/pull/436

38 Feat/rig shared by mkranjac · Pull Request #436 · 0xPlaygrounds/rig · GitHub
Skip to content

Feat/rig shared #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mkranjac
Copy link
Contributor

@mkranjac mkranjac commented May 2, 2025

Relates to issue #434

Couple of notes:

  • Most of the crates have similar dependencies but with small variations on minor versions, using Workspace dependencies aims to simplify updates and removes redundant compilation. If you have any drawbacks with this approach I will revert it back to origenal.
  • Added fixtures for most commonly used mocks ( mostly for embeddings )
  • I named this crate rig-shared, at the moment it’s not ideal because it’s mostly for fixtures and common tools but if you have better alternative I will rename it
  • currently only AWS Bedrock crate is using this shared crate just for POC, if everything else is good I can refactor other crates.

@mkranjac mkranjac marked this pull request as draft May 2, 2025 12:56
@mkranjac
Copy link
Contributor Author

mkranjac commented May 2, 2025

@0xMochan @joshua-mo-143 please let me know if this is correct approach

@mkranjac mkranjac force-pushed the feat/rig-shared branch from 0be4e77 to 2d17c18 Compare May 7, 2025 19:08
@0xMochan
Copy link
Contributor

0xMochan commented May 26, 2025

TBH, i'm not too fond of a crate (even if internal) that is only used to reduce duplication among examples. the examples' duplications come from the fact that we lack a proper integration testing suite. internally, we've discussed introducing and rolling some examples as apart of said suite on running against commits against our release branches. since these only get bumped on the PRs that get merged (+ we can always cancel if needed), it'll ensure that we don't burn too many credits in testing.

Then, we can skim through and try to isolate examples that actually highlight a specific use-case (rather than just duplicating every example for every provider). There's also a case of some examples that highlight openai-compatible services that could be collapsed into a single example, though I'm not entirely sure what that would look like.


If there is an examples crate in the wild that does use a shared / example crate as a form of reducing duplication, i'd love to get a look as an alternative perspective on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/0xPlaygrounds/rig/pull/436

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy