Skip to content
This repository was archived by the owner on Dec 31, 2023. It is now read-only.

feat: Switch to string enums for compute (#685) #158

Merged
merged 12 commits into from
Nov 29, 2021
Merged

feat: Switch to string enums for compute (#685) #158

merged 12 commits into from
Nov 29, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Nov 19, 2021

  • Regenerate this pull request now.

Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts).

Also cleanup regenerate other files (grpc_service_config and service yaml)
Source-Link: googleapis/googleapis@8ce4ea6

Source-Link: https://github.com/googleapis/googleapis-gen/commit/55e242c7cf5e600fabb8d767bd06f4fdfad6a015
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTVlMjQyYzdjZjVlNjAwZmFiYjhkNzY3YmQwNmY0ZmRmYWQ2YTAxNSJ9

@gcf-owl-bot
feat: Switch to string enums for compute (#685)
4ceadff 
Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts).

Also cleanup regenerate other files (grpc_service_config and service yaml)
Source-Link: googleapis/googleapis@8ce4ea6

Source-Link: https://github.com/googleapis/googleapis-gen/commit/55e242c7cf5e600fabb8d767bd06f4fdfad6a015
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTVlMjQyYzdjZjVlNjAwZmFiYjhkNzY3YmQwNmY0ZmRmYWQ2YTAxNSJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners November 19, 2021 02:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Nov 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 19, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 19, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 19, 2021
parthea
parthea suggested changes Nov 19, 2021
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System tests are failing

@gcf-owl-bot gcf-owl-bot bot requested review from m-strzelczyk and a team as code owners November 25, 2021 10:20
@gcf-owl-bot gcf-owl-bot bot requested a review from nicain November 25, 2021 10:20
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@parthea parthea force-pushed the owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0 branch from 185428e to 65911eb Compare November 25, 2021 19:23
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@parthea parthea force-pushed the owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0 branch from 65911eb to 8e9d5c5 Compare November 25, 2021 19:30
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 25, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 25, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 25, 2021
@parthea parthea assigned m-strzelczyk and unassigned m-strzelczyk Nov 25, 2021
@parthea
Copy link
Contributor

parthea commented Nov 26, 2021

@m-strzelczyk Please could you review/approve?

@m-strzelczyk m-strzelczyk assigned parthea and unassigned m-strzelczyk Nov 29, 2021
@parthea parthea merged commit 6cfa01e into main Nov 29, 2021
@parthea parthea deleted the owl-bot-9f21b9c6-54f2-4ee3-aea7-8cf1787e04e0 branch November 29, 2021 11:47
@release-please release-please bot mentioned this pull request Jan 13, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-owners

Assignees

@parthea parthea

Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @m-strzelczyk @yoshi-kokoro
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy