feat!: remove Start/EndTime from LogSink, Metadata from LogEntry, implement multipattern resource names #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng documentai as an example. Depends on googleapis/gapic-generator-python#402 PiperOrigin-RevId: 309824146 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon May 4 15:06:44 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb Source-Link: googleapis/googleapis@e0f9d9e
Restores GAPIC v2 retry config overrides that were mistakenly removed during migration. PiperOrigin-RevId: 312088359 Source-Author: Google APIs <noreply@google.com> Source-Date: Mon May 18 08:57:12 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c Source-Link: googleapis/googleapis@5a90d46
…sions - protobuf v3.12.1 - rules_go v0.23.0 - gazelle v0.21.0 - gapic-generator-go v0.14.1 PiperOrigin-RevId: 313460921 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed May 27 14:10:16 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: c4e37010d74071851ff24121f522e802231ac86e Source-Link: googleapis/googleapis@c4e3701
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
============================================
- Coverage 76.73% 75.17% -1.56%
- Complexity 579 593 +14
============================================
Files 42 42
Lines 3426 3646 +220
Branches 237 251 +14
============================================
+ Hits 2629 2741 +112
- Misses 651 757 +106
- Partials 146 148 +2
Continue to review full report at Codecov.
|
kolea2
approved these changes
Jun 22, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerates the Logging Client with the v2 Gapic configuration which includes multi-pattern resource names
NOTE if you are only using the hand-written layer, no changes should be necessary. The protobuf messages and generated clients are part of the public surface area so this is a major version bump.
Breaking proto message changes
startTimeandendTimefields fromLogSinkprotobuf messagemetadatafield fromLogEntryprotobuf messageResource ames
Rather than providing an abstract base class for a resource name type, we provide a concrete base class which serves as the default resource name.
For example, we previously provided an abstract class
LogNamewith concrete implementations ofBillingLogName,FolderLogName,OrganizationLogName, andProjectLogNamefrom which you would pick one to use. NowLogNamebehaves like aProjectLogNameby default but can also be used to build all types -LogName.ofProjectLogName,LogName.ofBillingLogName,LogName.ofFolderLogName,LogName.ofOrganizationLogName. If you were using theLogNames.parse(String)static method, you can now useLogName.parse(String).PiperOrigin-RevId: 313460921
Source-Link: googleapis/googleapis@c4e3701
PiperOrigin-RevId: 312088359
Source-Link: googleapis/googleapis@5a90d46
PiperOrigin-RevId: 309824146
Source-Link: googleapis/googleapis@e0f9d9e
BREAKING CHANGE:
com.google.cloud.loggingclasses (without the v2), you should not need to change any code.