Skip to content

Commit b171e03

Browse files
authored
Fix cancelling of Pull Request builds when image build fails (apache#20939)
When image build fails, the pull request that triggered it should be cancelled. The apache#15944 introduced rewrite of the GitHub actions code but by mistake it also introduced a failure in cancelling the PR workflow by missing pipeline to jq. In most cases it did not matter, but it cause "wait for images" in PRs to run far longer than they should be. This PR restores cancelling feature.
1 parent 0e4a057 commit b171e03

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build-images.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ jobs:
337337
fi
338338
339339
for cancel_url in $(
340-
gh api "/repos/$GITHUB_REPOSITORY/actions/runs?${event_filter}branch=${branch}" \
340+
gh api "/repos/$GITHUB_REPOSITORY/actions/runs?${event_filter}branch=${branch}" | \
341341
jq -r '
342342
.workflow_runs[] |
343343
select(.head_sha == $ENV.GITHUB_REGISTRY_PUSH_IMAGE_TAG and .status != "completed") |

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy