Skip to content

feat(eslint-plugin): add a default-off option to autofix remove unused imports #11243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat(eslint-plugin): add a default-off option to autofix remove unused imports #11243

wants to merge 3 commits into from

Conversation

nayounsang
Copy link

PR Checklist

Overview

DRAFT

  • When add option enableAutofixRemoval: { imports: true } , auto fix and remove unused import statement
  • Add test case in issue
  • More test cases are needed. First of all, since it is my first contribution, it is very difficult, so I will think about it after uploading the PR. I can check the comments quickly.
  • There may be something wrong with the comma handling. First, pass the test case.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented May 23, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7fc5d69
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6831c313e2a5d600083d1c13
😎 Deploy Preview https://deploy-preview-11243--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nayounsang nayounsang marked this pull request as draft May 23, 2025 15:53
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented May 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 7fc5d69.

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 3s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 8s View ↗
nx run types:build ✅ Succeeded <1s View ↗
nx run-many -t lint ✅ Succeeded 9s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded <1s View ↗
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded <1s View ↗
nx run integration-tests:test ✅ Succeeded <1s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-05-24 13:13:28 UTC

@nayounsang
Copy link
Author

Wow, when adding a new feature, a follow-up development is needed. I'll work on it tomorrow.

@codecov Codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 85.36585% with 12 lines in your changes missing coverage. Please review.

Project coverage is 90.90%. Comparing base (4ad8a07) to head (7fc5d69).

Files with missing lines Patch % Lines
packages/eslint-plugin/src/rules/no-unused-vars.ts 85.36% 12 Missing ⚠️

❌ Your patch check has failed because the patch coverage (85.36%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11243      +/-   ##
==========================================
- Coverage   90.91%   90.90%   -0.01%     
==========================================
  Files         501      501              
  Lines       50869    50951      +82     
  Branches     8382     8403      +21     
==========================================
+ Hits        46248    46318      +70     
- Misses       4606     4618      +12     
  Partials       15       15
Flag Coverage Δ
unittest 90.90% <85.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts 98.25% <85.36%> (-1.75%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nayounsang
nayounsang commented May 24, 2025
View reviewed changes
packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
@@ -2946,39 +3062,6 @@ declare module 'foo' {
{
code: `
export import Bar = Something.Bar;
const foo: 1234;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is github doing the comparison wrong? I checked and there is no part that has been deleted. There is no reason to delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [no-unused-vars] add a default-off option to autofix remove unused imports
1 participant
@nayounsang
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy