fix(eslint-plugin): [no-unsafe-member-access] ignore MemberExpression's whose parents are either TSClassImplements or TSInterfaceHeritage (typescript-eslint#2753)

hsmitty93 · web-flow · commit 535db3bf27ee · 2020-11-10T22:36:13.000-08:00
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts b/packages/eslint-plugin/src/rules/no-unsafe-member-access.ts
@@ -71,7 +71,8 @@ export default util.createRule({
     }
 
     return {
-      MemberExpression: checkMemberExpression,
+      // ignore MemberExpression if it's parent is TSClassImplements or TSInterfaceHeritage
+      ':not(TSClassImplements, TSInterfaceHeritage) > MemberExpression': checkMemberExpression,
       'MemberExpression[computed = true] > *.property'(
         node: TSESTree.Expression,
       ): void {
diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-member-access.test.ts
@@ -66,6 +66,12 @@ function foo(x?: string[]) {
   x?.[(1 as any)++];
 }
     `,
+    `
+class B implements FG.A {}
+    `,
+    `
+interface B extends FG.A {}
+    `,
   ],
   invalid: [
     ...batchedSingleLineTests({

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,8 @@ export default util.createRule({`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`return {`
`74`		`- MemberExpression: checkMemberExpression,`
	`74`	`+ // ignore MemberExpression if it's parent is TSClassImplements or TSInterfaceHeritage`
	`75`	`+ ':not(TSClassImplements, TSInterfaceHeritage) > MemberExpression': checkMemberExpression,`
`75`	`76`	`'MemberExpression[computed = true] > *.property'(`
`76`	`77`	`node: TSESTree.Expression,`
`77`	`78`	`): void {`