fix(scope-manager): fix visiting TSAsExpression in assignment (typescript-eslint#3355)

yeonjuan · web-flow · commit 87521a024103 · 2021-05-09T10:05:05.000-07:00
diff --git a/packages/eslint-plugin/tests/eslint-rules/no-undef.test.ts b/packages/eslint-plugin/tests/eslint-rules/no-undef.test.ts
@@ -139,6 +139,13 @@ function predicate(arg: any): asserts arg is T {
     throw 'oops';
   }
 }
+    `,
+    `
+interface ITest {
+  attr: string;
+}
+let test: unknown;
+(test as ITest) = { attr: '' };
     `,
     {
       code: `
diff --git a/packages/scope-manager/src/referencer/Referencer.ts b/packages/scope-manager/src/referencer/Referencer.ts
@@ -320,7 +320,7 @@ class Referencer extends Visitor {
       case AST_NODE_TYPES.TSAsExpression:
       case AST_NODE_TYPES.TSTypeAssertion:
         // explicitly visit the type annotation
-        this.visit(left.typeAnnotation);
+        this.visitType(left.typeAnnotation);
       // intentional fallthrough
       case AST_NODE_TYPES.TSNonNullExpression:
         // unwrap the expression

Original file line number	Diff line number	Diff line change
`@@ -139,6 +139,13 @@ function predicate(arg: any): asserts arg is T {`
`139`	`139`	`throw 'oops';`
`140`	`140`	`}`
`141`	`141`	`}`
	`142`	+ `,
	`143`	+ `
	`144`	`+interface ITest {`
	`145`	`+ attr: string;`
	`146`	`+}`
	`147`	`+let test: unknown;`
	`148`	`+(test as ITest) = { attr: '' };`
`142`	`149`	`,
`143`	`150`	`{`
`144`	`151`	code: `