Remove PEP-604 methods from Sentinel on Python <3.10 (#605)

AlexWaygood · web-flow · commit fadc1edbcfd9 · 2025-05-25T08:42:04.000-07:00
We don't generally try to "backport PEP 604" on Python &lt;3.10; this is more consistent with our features
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+# Unreleased
+
+- Remove `__or__` and `__ror__` methods from `typing_extensions.Sentinel`
+  on Python versions <3.10. PEP 604 was introduced in Python 3.10, and
+  `typing_extensions` does not generally attempt to backport PEP-604 methods
+  to prior versions.
+
 # Release 4.14.0rc1 (May 24, 2025)
 
 - Drop support for Python 3.8 (including PyPy-3.8). Patch by [Victorien Plot](https://github.com/Viicos).
diff --git a/src/typing_extensions.py b/src/typing_extensions.py
@@ -4244,11 +4244,12 @@ def __repr__(self):
         def __call__(self, *args, **kwargs):
             raise TypeError(f"{type(self).__name__!r} object is not callable")
 
-    def __or__(self, other):
-        return typing.Union[self, other]
+    if sys.version_info >= (3, 10):
+        def __or__(self, other):
+            return typing.Union[self, other]
 
-    def __ror__(self, other):
-        return typing.Union[other, self]
+        def __ror__(self, other):
+            return typing.Union[other, self]
 
     def __getstate__(self):
         raise TypeError(f"Cannot pickle {type(self).__name__!r} object")
