Skip to content

MAINT: Convert lapack_lite to multi-phase init (PEP 489) #29029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

MAINT: Convert lapack_lite to multi-phase init (PEP 489) #29029

merged 1 commit into from
May 28, 2025
+39 −23

Conversation

AA-Turner
Copy link
Contributor

@AA-Turner AA-Turner commented May 21, 2025 •
edited
Loading

@AA-Turner AA-Turner mentioned this pull request May 21, 2025
Open
@AA-Turner AA-Turner force-pushed the multi-phase/lapack_lite branch 2 times, most recently from 26301e9 to 9cde821 Compare May 22, 2025 02:57
@AA-Turner AA-Turner marked this pull request as draft May 24, 2025 06:22
@AA-Turner AA-Turner force-pushed the multi-phase/lapack_lite branch from 9cde821 to d53f13f Compare May 28, 2025 11:21
@AA-Turner AA-Turner marked this pull request as ready for review May 28, 2025 12:28
@AA-Turner
Copy link
Contributor Author

AA-Turner commented May 28, 2025 •
edited
Loading

Test failure seems unrelated: FAILED numpy/linalg/tests/test_linalg.py::TestQR::test_stacked_inputs[float32-outer_size2-size1] - RuntimeWarning: invalid value encountered in matmul. I don't have access to macOS to reproduce, though, sorry.

cc @seberg

@seberg
Copy link
Member

seberg commented May 28, 2025

Looks right to me, yes, the error comes up occasionally, some weird blas thing probably.
Refusing multiple inits is correct, although one may hope that the module is maybe not hard to convert.
(not actually sure, while certainly possible the ufuncs may need work.)

@seberg seberg changed the title GH-29021: Convert lapack_lite to multi-phase init (PEP 489) MAINT: Convert lapack_lite to multi-phase init (PEP 489) May 28, 2025
@seberg seberg merged commit 0145d7c into numpy:main May 28, 2025
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @seberg
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy