fix: Don't restrict length for commit message footer (#467)

hashtagchris · hashtagchris · commit 6ee703d12a4f · 2024-08-05T16:31:24.000-04:00
Our breaking change footers related to engine changes are often >100 characters, resulting in commitlint CI failures.  Example CI failure: https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12 Associated PR: npm/ssri#137
diff --git a/.commitlintrc.js b/.commitlintrc.js
@@ -7,5 +7,6 @@ module.exports = {
     'header-max-length': [2, 'always', 80],
     'subject-case': [0],
     'body-max-line-length': [0],
+    'footer-max-line-length': [0],
   },
 }
diff --git a/lib/content/commitlintrc-js.hbs b/lib/content/commitlintrc-js.hbs
@@ -5,5 +5,6 @@ module.exports = {
     'header-max-length': [2, 'always', 80],
     'subject-case': [0],
     'body-max-line-length': [0],
+    'footer-max-line-length': [0],
   },
 }
diff --git a/tap-snapshots/test/apply/source-snapshots.js.test.cjs b/tap-snapshots/test/apply/source-snapshots.js.test.cjs
@@ -17,6 +17,7 @@ module.exports = {
     'header-max-length': [2, 'always', 80],
     'subject-case': [0],
     'body-max-line-length': [0],
+    'footer-max-line-length': [0],
   },
 }
 
@@ -1455,6 +1456,7 @@ module.exports = {
     'header-max-length': [2, 'always', 80],
     'subject-case': [0],
     'body-max-line-length': [0],
+    'footer-max-line-length': [0],
   },
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,6 @@ module.exports = {`
`7`	`7`	`'header-max-length': [2, 'always', 80],`
`8`	`8`	`'subject-case': [0],`
`9`	`9`	`'body-max-line-length': [0],`
	`10`	`+ 'footer-max-line-length': [0],`
`10`	`11`	`},`
`11`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,6 @@ module.exports = {`
`5`	`5`	`'header-max-length': [2, 'always', 80],`
`6`	`6`	`'subject-case': [0],`
`7`	`7`	`'body-max-line-length': [0],`
	`8`	`+ 'footer-max-line-length': [0],`
`8`	`9`	`},`
`9`	`10`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ module.exports = {`
`17`	`17`	`'header-max-length': [2, 'always', 80],`
`18`	`18`	`'subject-case': [0],`
`19`	`19`	`'body-max-line-length': [0],`
	`20`	`+ 'footer-max-line-length': [0],`
`20`	`21`	`},`
`21`	`22`	`}`
`22`	`23`
`@@ -1455,6 +1456,7 @@ module.exports = {`
`1455`	`1456`	`'header-max-length': [2, 'always', 80],`
`1456`	`1457`	`'subject-case': [0],`
`1457`	`1458`	`'body-max-line-length': [0],`
	`1459`	`+ 'footer-max-line-length': [0],`
`1458`	`1460`	`},`
`1459`	`1461`	`}`
`1460`	`1462`