fix(eslint-plugin): [consistent-type-assertions] check type assertion in jsx props (typescript-eslint#2653)

yeonjuan · web-flow · commit 393e92573fbd · 2020-10-11T16:55:33.000-07:00
diff --git a/packages/eslint-plugin/docs/rules/consistent-type-assertions.md b/packages/eslint-plugin/docs/rules/consistent-type-assertions.md
@@ -74,13 +74,14 @@ function foo(): T {
 
 Examples of **correct** code for `{ assertionStyle: 'as', objectLiteralTypeAssertions: 'allow-as-parameter' }`.
 
-```ts
+```tsx
 const x: T = { ... };
 const y = { ... } as any;
 const z = { ... } as unknown;
 foo({ ... } as T);
 new Clazz({ ... } as T);
 function foo() { throw { bar: 5 } as Foo }
+const foo = <Foo props={{ ... } as Bar}/>;
 ```
 
 ## When Not To Use It
diff --git a/packages/eslint-plugin/src/rules/consistent-type-assertions.ts b/packages/eslint-plugin/src/rules/consistent-type-assertions.ts
@@ -140,7 +140,8 @@ export default util.createRule<Options, MessageIds>({
         (node.parent.type === AST_NODE_TYPES.NewExpression ||
           node.parent.type === AST_NODE_TYPES.CallExpression ||
           node.parent.type === AST_NODE_TYPES.ThrowStatement ||
-          node.parent.type === AST_NODE_TYPES.AssignmentPattern)
+          node.parent.type === AST_NODE_TYPES.AssignmentPattern ||
+          node.parent.type === AST_NODE_TYPES.JSXExpressionContainer)
       ) {
         return;
       }
diff --git a/packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts b/packages/eslint-plugin/tests/rules/consistent-type-assertions.test.ts
@@ -112,6 +112,20 @@ ruleTester.run('consistent-type-assertions', rule, {
         },
       ],
     },
+    {
+      code: 'const bar = <Foo style={{ bar: 5 } as Bar} />;',
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+      options: [
+        {
+          assertionStyle: 'as',
+          objectLiteralTypeAssertions: 'allow-as-parameter',
+        },
+      ],
+    },
   ],
   invalid: [
     ...batchedSingleLineTests({
@@ -342,5 +356,24 @@ ruleTester.run('consistent-type-assertions', rule, {
         },
       ],
     }),
+    {
+      code: 'const foo = <Foo style={{ bar: 5 } as Bar} />;',
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+      options: [
+        {
+          assertionStyle: 'never',
+        },
+      ],
+      errors: [
+        {
+          messageId: 'never',
+          line: 1,
+        },
+      ],
+    },
   ],
 });
