fix(eslint-plugin): [no-unsafe-return] error with <TS3.7 (typescript-eslint#1815)

bradzacher · web-flow · commit f3160b471f82 · 2020-03-27T18:31:43.000-07:00
diff --git a/packages/eslint-plugin/src/util/types.ts b/packages/eslint-plugin/src/util/types.ts
@@ -323,7 +323,12 @@ export function isAnyOrAnyArrayTypeDiscriminated(
   }
   if (
     checker.isArrayType(type) &&
-    isTypeAnyType(checker.getTypeArguments(type)[0])
+    isTypeAnyType(
+      // getTypeArguments was only added in TS3.7
+      checker.getTypeArguments
+        ? checker.getTypeArguments(type)[0]
+        : (type.typeArguments ?? [])[0],
+    )
   ) {
     return AnyType.AnyArray;
   }

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,12 @@ export function isAnyOrAnyArrayTypeDiscriminated(`
`323`	`323`	`}`
`324`	`324`	`if (`
`325`	`325`	`checker.isArrayType(type) &&`
`326`		`- isTypeAnyType(checker.getTypeArguments(type)[0])`
	`326`	`+ isTypeAnyType(`
	`327`	`+ // getTypeArguments was only added in TS3.7`
	`328`	`+ checker.getTypeArguments`
	`329`	`+ ? checker.getTypeArguments(type)[0]`
	`330`	`+ : (type.typeArguments ?? [])[0],`
	`331`	`+ )`
`327`	`332`	`) {`
`328`	`333`	`return AnyType.AnyArray;`
`329`	`334`	`}`