fix(eslint-plugin): explicit-function-return-type: ensure class arrow methods are validated (typescript-eslint#377)

gavinbarron · bradzacher · commit 643a223d6298 · 2019-03-27T11:59:50.000-07:00
Fixes typescript-eslint#348
diff --git a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts
@@ -114,6 +114,7 @@ export default util.createRule<Options, MessageIds>({
     ): void {
       if (
         options.allowExpressions &&
+        node.type !== AST_NODE_TYPES.ArrowFunctionExpression &&
         node.parent &&
         node.parent.type !== AST_NODE_TYPES.VariableDeclarator &&
         node.parent.type !== AST_NODE_TYPES.MethodDefinition
diff --git a/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts b/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts
@@ -41,6 +41,7 @@ class Test {
   method(): void {
     return;
   }
+  arrow = (): string => 'arrow';
 }
             `,
     },
@@ -171,6 +172,7 @@ class Test {
   method() {
     return;
   }
+  arrow = () => 'arrow';
 }
             `,
       errors: [
@@ -184,6 +186,11 @@ class Test {
           line: 8,
           column: 9,
         },
+        {
+          messageId: 'missingReturnType',
+          line: 11,
+          column: 11,
+        },
       ],
     },
     {

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ class Test {`
`41`	`41`	`method(): void {`
`42`	`42`	`return;`
`43`	`43`	`}`
	`44`	`+ arrow = (): string => 'arrow';`
`44`	`45`	`}`
`45`	`46`	`,
`46`	`47`	`},`
`@@ -171,6 +172,7 @@ class Test {`
`171`	`172`	`method() {`
`172`	`173`	`return;`
`173`	`174`	`}`
	`175`	`+ arrow = () => 'arrow';`
`174`	`176`	`}`
`175`	`177`	`,
`176`	`178`	`errors: [`
`@@ -184,6 +186,11 @@ class Test {`
`184`	`186`	`line: 8,`
`185`	`187`	`column: 9,`
`186`	`188`	`},`
	`189`	`+ {`
	`190`	`+ messageId: 'missingReturnType',`
	`191`	`+ line: 11,`
	`192`	`+ column: 11,`
	`193`	`+ },`
`187`	`194`	`],`
`188`	`195`	`},`
`189`	`196`	`{`