chore(ast-spec): simplify Literal types (typescript-eslint#3769)

MichaelDeBoey · web-flow · commit f62baec3a6a8 · 2021-09-03T10:47:26.000-07:00
diff --git a/packages/ast-spec/src/base/LiteralBase.ts b/packages/ast-spec/src/base/LiteralBase.ts
@@ -1,6 +1,8 @@
+import type { AST_NODE_TYPES } from '../ast-node-types';
 import type { BaseNode } from './BaseNode';
 
 export interface LiteralBase extends BaseNode {
+  type: AST_NODE_TYPES.Literal;
   raw: string;
   value: RegExp | bigint | boolean | number | string | null;
 }
diff --git a/packages/ast-spec/src/expression/literal/BigIntLiteral/spec.ts b/packages/ast-spec/src/expression/literal/BigIntLiteral/spec.ts
@@ -1,8 +1,6 @@
-import type { AST_NODE_TYPES } from '../../../ast-node-types';
 import type { LiteralBase } from '../../../base/LiteralBase';
 
 export interface BigIntLiteral extends LiteralBase {
-  type: AST_NODE_TYPES.Literal;
   value: bigint | null;
   bigint: string;
 }
diff --git a/packages/ast-spec/src/expression/literal/BooleanLiteral/spec.ts b/packages/ast-spec/src/expression/literal/BooleanLiteral/spec.ts
@@ -1,8 +1,6 @@
-import type { AST_NODE_TYPES } from '../../../ast-node-types';
 import type { LiteralBase } from '../../../base/LiteralBase';
 
 export interface BooleanLiteral extends LiteralBase {
-  type: AST_NODE_TYPES.Literal;
   value: boolean;
   raw: 'false' | 'true';
 }
diff --git a/packages/ast-spec/src/expression/literal/NullLiteral/spec.ts b/packages/ast-spec/src/expression/literal/NullLiteral/spec.ts
@@ -1,8 +1,6 @@
-import type { AST_NODE_TYPES } from '../../../ast-node-types';
 import type { LiteralBase } from '../../../base/LiteralBase';
 
 export interface NullLiteral extends LiteralBase {
-  type: AST_NODE_TYPES.Literal;
   value: null;
   raw: 'null';
 }
diff --git a/packages/ast-spec/src/expression/literal/NumberLiteral/spec.ts b/packages/ast-spec/src/expression/literal/NumberLiteral/spec.ts
@@ -1,7 +1,5 @@
-import type { AST_NODE_TYPES } from '../../../ast-node-types';
 import type { LiteralBase } from '../../../base/LiteralBase';
 
 export interface NumberLiteral extends LiteralBase {
-  type: AST_NODE_TYPES.Literal;
   value: number;
 }
diff --git a/packages/ast-spec/src/expression/literal/RegExpLiteral/spec.ts b/packages/ast-spec/src/expression/literal/RegExpLiteral/spec.ts
@@ -1,8 +1,6 @@
-import type { AST_NODE_TYPES } from '../../../ast-node-types';
 import type { LiteralBase } from '../../../base/LiteralBase';
 
 export interface RegExpLiteral extends LiteralBase {
-  type: AST_NODE_TYPES.Literal;
   value: RegExp | null;
   regex: {
     pattern: string;
diff --git a/packages/ast-spec/src/expression/literal/StringLiteral/spec.ts b/packages/ast-spec/src/expression/literal/StringLiteral/spec.ts
@@ -1,7 +1,5 @@
-import type { AST_NODE_TYPES } from '../../../ast-node-types';
 import type { LiteralBase } from '../../../base/LiteralBase';
 
 export interface StringLiteral extends LiteralBase {
-  type: AST_NODE_TYPES.Literal;
   value: string;
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,8 @@`
	`1`	`+import type { AST_NODE_TYPES } from '../ast-node-types';`
`1`	`2`	`import type { BaseNode } from './BaseNode';`
`2`	`3`
`3`	`4`	`export interface LiteralBase extends BaseNode {`
	`5`	`+ type: AST_NODE_TYPES.Literal;`
`4`	`6`	`raw: string;`
`5`	`7`	`value: RegExp \| bigint \| boolean \| number \| string \| null;`
`6`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,6 @@`
`1`		`-import type { AST_NODE_TYPES } from '../../../ast-node-types';`
`2`	`1`	`import type { LiteralBase } from '../../../base/LiteralBase';`
`3`	`2`
`4`	`3`	`export interface BigIntLiteral extends LiteralBase {`
`5`		`- type: AST_NODE_TYPES.Literal;`
`6`	`4`	`value: bigint \| null;`
`7`	`5`	`bigint: string;`
`8`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`		`-import type { AST_NODE_TYPES } from '../../../ast-node-types';`
`2`	`1`	`import type { LiteralBase } from '../../../base/LiteralBase';`
`3`	`2`
`4`	`3`	`export interface NumberLiteral extends LiteralBase {`
`5`		`- type: AST_NODE_TYPES.Literal;`
`6`	`4`	`value: number;`
`7`	`5`	`}`