#1391 Improve log messaging for non-restful controller

ipolevoy · ipolevoy · commit 5e4f0c0ab0a9 · 2025-05-19T10:05:57.000-05:00
diff --git a/activeweb-testing/src/test/java/app/controllers/MyRestfulControllerSpec.java b/activeweb-testing/src/test/java/app/controllers/MyRestfulControllerSpec.java
@@ -25,7 +25,8 @@ public void should_prevent_wrong_HTTP_method(){
         SystemStreamUtil.replaceOut();
         controller("/my_restful").post("index");
         the(statusCode()).shouldEqual(405);
-        the(SystemStreamUtil.getSystemOut()).shouldContain("Cannot execute a non-restful action on a restful controller.");
+        the(SystemStreamUtil.getSystemOut()).shouldContain("Cannot execute a non-restful action on a restful controller: app.controllers.MyRestfulController#index");
+        the(SystemStreamUtil.getSystemOut()).shouldContain("app.controllers.MyRestfulController#index action does not support HTTP method: POST, returning status code 405.");
         SystemStreamUtil.restoreSystemOut();
     }
 }
diff --git a/activeweb/src/main/java/org/javalite/activeweb/Route.java b/activeweb/src/main/java/org/javalite/activeweb/Route.java
@@ -169,7 +169,7 @@ boolean actionSupportsHTTPMethod() {
             DirectResponse res = new DirectResponse("405 - Method not allowed");
             //see http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
             res.setStatus(405);
-            LOGGER.warn("Requested action does not support HTTP method: " + method.name() + ", returning status code 405.");
+            LOGGER.warn("{} action does not support HTTP method: " + method.name() + ", returning status code 405.", getControllerClassName() + "#" + getActionName());
             RequestContext.setControllerResponse(res);
             //see http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
             RequestContext.getHttpResponse().setHeader("Allow", join(allowedActions(), ", "));
@@ -227,7 +227,7 @@ private boolean restfulActionSupportsHttpMethod() {
                 || actionName.equals("options") && httpMethod.equals(HttpMethod.OPTIONS)) {
             return true;
         } else {
-            LOGGER.warn("Cannot execute a non-restful action on a restful controller.");
+            LOGGER.warn("Cannot execute a non-restful action on a restful controller: {}", controller.getClass().getName() + "#" + actionMethod.getName() );
             return false;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ public void should_prevent_wrong_HTTP_method(){`
`25`	`25`	`SystemStreamUtil.replaceOut();`
`26`	`26`	`controller("/my_restful").post("index");`
`27`	`27`	`the(statusCode()).shouldEqual(405);`
`28`		`- the(SystemStreamUtil.getSystemOut()).shouldContain("Cannot execute a non-restful action on a restful controller.");`
	`28`	`+ the(SystemStreamUtil.getSystemOut()).shouldContain("Cannot execute a non-restful action on a restful controller: app.controllers.MyRestfulController#index");`
	`29`	`+ the(SystemStreamUtil.getSystemOut()).shouldContain("app.controllers.MyRestfulController#index action does not support HTTP method: POST, returning status code 405.");`
`29`	`30`	`SystemStreamUtil.restoreSystemOut();`
`30`	`31`	`}`
`31`	`32`	`}`