feat(eslint-plugin): [explicit-function-return-type] add support for typed class property definitions (typescript-eslint#8027)

auvred · web-flow · commit bff47d7885be · 2023-12-05T14:45:22.000-05:00
diff --git a/packages/eslint-plugin/src/util/explicitReturnTypeUtils.ts b/packages/eslint-plugin/src/util/explicitReturnTypeUtils.ts
@@ -336,6 +336,11 @@ function ancestorHasReturnType(node: FunctionNode): boolean {
           return true;
         }
         break;
+      case AST_NODE_TYPES.PropertyDefinition:
+        if (ancestor.typeAnnotation) {
+          return true;
+        }
+        break;
     }
 
     ancestor = ancestor.parent;
diff --git a/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts b/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts
@@ -713,6 +713,26 @@ let foo = (() => (() => {})())();
         },
       ],
     },
+    {
+      code: `
+class Bar {
+  bar: Foo = {
+    foo: x => x + 1,
+  };
+}
+      `,
+    },
+    {
+      code: `
+class Bar {
+  bar: Foo[] = [
+    {
+      foo: x => x + 1,
+    },
+  ];
+}
+      `,
+    },
   ],
   invalid: [
     {
@@ -1651,6 +1671,26 @@ class Foo {
     },
     {
       code: `
+class Bar {
+  bar = [
+    {
+      foo: x => x + 1,
+    },
+  ];
+}
+      `,
+      errors: [
+        {
+          messageId: 'missingReturnType',
+          line: 5,
+          endLine: 5,
+          column: 7,
+          endColumn: 12,
+        },
+      ],
+    },
+    {
+      code: `
 const foo = (function () {
   return 'foo';
 })();

Original file line number	Diff line number	Diff line change
`@@ -336,6 +336,11 @@ function ancestorHasReturnType(node: FunctionNode): boolean {`
`336`	`336`	`return true;`
`337`	`337`	`}`
`338`	`338`	`break;`
	`339`	`+ case AST_NODE_TYPES.PropertyDefinition:`
	`340`	`+ if (ancestor.typeAnnotation) {`
	`341`	`+ return true;`
	`342`	`+ }`
	`343`	`+ break;`
`339`	`344`	`}`
`340`	`345`
`341`	`346`	`ancestor = ancestor.parent;`