[ggj][ast][engx] fix: validate non-null elements for GeneralForStatement (#462)

miraleung · web-flow · commit 018e6b1f4f8a · 2020-11-06T21:43:50.000-08:00
* fix: swap assertEquals args in JavaWriterVisitorTest to match (expected, actusl) order

* fix: swap assertEquals args in ImportWriterVisitorTest to match (expected, actusl) order

* fix: add node validator to refactor/centralize null element checks

* fix: validate non-null elements for IfStatement

* fix: validate non-null elements for AnonymousClassExpr

* fix: validate non-null elements for BlockStatement

* fix: validate non-null elements for ClassDefinition

* fix: validate non-null elements for ConcreteReference

* fix: validate non-null elements for ForStatement

* fix: validate non-null elements for GeneralForStatement
diff --git a/src/main/java/com/google/api/generator/engine/ast/GeneralForStatement.java b/src/main/java/com/google/api/generator/engine/ast/GeneralForStatement.java
@@ -79,6 +79,8 @@ abstract static class Builder {
     // Type-checking will be done in the sub-expressions.
     GeneralForStatement build() {
       GeneralForStatement generalForStatement = autoBuild();
+      NodeValidator.checkNoNullElements(
+          generalForStatement.body(), "body", "general for-statement");
       Expr initExpr = generalForStatement.initializationExpr();
       if (initExpr instanceof AssignmentExpr) {
         VariableExpr localVarExpr = ((AssignmentExpr) initExpr).variableExpr();
