-
-
Notifications
You must be signed in to change notification settings - Fork 20
feat: add GitHub Actions to build release #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This will be super handy! If you run into trouble with v8 versions, this will soon be a lot easier when godotengine/godot#100749 lands in Godot. I've got a bunch of commits over at https://github.com/Benjamin-Dobell/GodotJS/commits/main/ that I need to clean up and upstream. Some of this is related to C++20. This will allow us to use the latest v8 (which requires C++20 to build). |
I uses Furthermore, I disabled the tests for now. Would be an improvement as well |
This looks pretty fantastic to me. Sorry about the merge conflict in Aside from that, unless @ialex32x, has some thoughts, I reckon you're good to merge this. A nice follow-up in future would be to introduce a super simple patch mechanism for the Godot Engine source. Main use case I have in mind would be to patch the URL in |
7a2a067
to
a880986
Compare
@nmerget I've just rebased this for you (since I broke it) 😅 I squashed the fix-up commits (duplicate commit messages) but kept individual commits for posterity. Assuming the actions run to completion, I'll merge it when they're done. |
@nmerget Thanks so much for putting this together! It's a massive improvement. 🎉 |
@Benjamin-Dobell I would have squashed it before during the merge ^.^ |
At the moment we point to |
Add GitHub workflow to build and release GodotJS