Unable to remove filter on Games example #202
Comments
|
On 20 October 2017 at 13:41, Chris Wood ***@***.***> wrote:
The games example
<http://epimorphics.github.io/elda/current/index.html#games-example--web-page>
of elda states And you can apply more than one filter, perhaps asking for
seven-player games from before 2005.
I've successfully managed to do this (although the example dataset in the
current version doesn't seem to have *any* seven-player games), so if we
pick six-player games from 2009, then we get 1 result ("A Brief History of
the World"). However, the view menu only lists one of the filters (Remove
current filter: players 6):
Hi Chris
I won't be able to work on this over next week, as I'm on holiday.
Could you (a) tell me which version of Elda you are using,
(b) if not the latest, then try with the latest (1.4.3), and (c)
raise an issue with that information in it?
Chris
…--
Chris "allusive" Dollin
|
|
Hi Chris, Yes, I'm using 1.4.3: |
|
Hmm. The min- and max- properties don' t seem to be added to the view. |
|
Page.filterRemovalLinks uses ShortnameRender.isKnownShortnamePath(String) to test Allowing isShortnamePath to accept leading min- and max- would fix this. Not intending to address this at this time, |
|
@ehedgehog If you just close the issue, there is no retained record of this being something that needs addressing. But the tone of of your comment is that we should address the problem that @wood-chris identified at some point, just not now. If we leave this issue closed, it should be added to a list somewhere of problems to address at some future date. But it might just be easier to leave it open? |
|
Good point.
…On 31 October 2017 at 10:08, Ian Dickinson ***@***.***> wrote:
@ehedgehog <https://github.com/ehedgehog> If you just close the issue,
there is no retained record of this being something that needs addressing.
But the tone of of your comment is that we should address the problem that
@wood-chris <https://github.com/wood-chris> identified at some point,
just not now. If we leave this issue closed, it should be added to a list
somewhere of problems to address at some future date. But it might just be
easier to leave it open?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#202 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAb1FGivgm6IQfU91IBOgh8N3nzX4XDzks5sxvGmgaJpZM4QAnPg>
.
--
Chris "allusive" Dollin
|
The games example of elda states
And you can apply more than one filter, perhaps asking for seven-player games from before 2005.I've successfully managed to do this (although the example dataset in the current version doesn't seem to have any seven-player games), so if we pick six-player games from 2009, then we get 1 result ("A Brief History of the World"). However, the
viewmenu only lists one of the filters (Remove current filter: players 6):If you remove the player number filter, there's no link to remove the publication year filter:
(the URI verifies that the filter is still being applied).
The text was updated successfully, but these errors were encountered: