fix(eslint-plugin): [efrt] support constructor arguments (typescript-eslint#1021)

a-tarasyuk · bradzacher · bradzacher · commit 60943e6f270e · 2019-10-06T20:35:41.000-07:00
Co-authored-by: Brad Zacher &lt;brad.zacher@gmail.com&gt;
diff --git a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts
@@ -152,6 +152,15 @@ export default util.createRule<Options, MessageIds>({
       );
     }
 
+    /**
+     * Checks if a node belongs to:
+     * new Foo(() => {})
+     *         ^^^^^^^^
+     */
+    function isConstructorArgument(parent: TSESTree.Node): boolean {
+      return parent.type === AST_NODE_TYPES.NewExpression;
+    }
+
     /**
      * Checks if a node is a type cast
      * `(() => {}) as Foo`
@@ -325,7 +334,8 @@ export default util.createRule<Options, MessageIds>({
             isVariableDeclaratorWithTypeAnnotation(node.parent) ||
             isClassPropertyWithTypeAnnotation(node.parent) ||
             isPropertyOfObjectWithType(node.parent) ||
-            isFunctionArgument(node.parent, node)
+            isFunctionArgument(node.parent, node) ||
+            isConstructorArgument(node.parent)
           ) {
             return;
           }
diff --git a/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts b/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts
@@ -322,6 +322,18 @@ const func = (value: number) => x as const;
         },
       ],
     },
+    {
+      filename: 'test.ts',
+      code: `
+new Promise(resolve => {});
+new Foo(1, () => {});
+      `,
+      options: [
+        {
+          allowTypedFunctionExpressions: true,
+        },
+      ],
+    },
   ],
   invalid: [
     {
