chore: enabled restrict-template-expressions internally (typescript-eslint#3854)

Josh Goldberg · web-flow · commit 955d7a62b2e8 · 2021-09-20T14:07:56.000-07:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -59,13 +59,21 @@ module.exports = {
     '@typescript-eslint/prefer-optional-chain': 'error',
     '@typescript-eslint/unbound-method': 'off',
     '@typescript-eslint/prefer-as-const': 'error',
+    '@typescript-eslint/restrict-template-expressions': [
+      'error',
+      {
+        allowNumber: true,
+        allowBoolean: true,
+        allowAny: true,
+        allowNullish: true,
+        allowRegExp: true,
+      },
+    ],
     '@typescript-eslint/no-unused-vars': [
       'warn',
       { varsIgnorePattern: '^_', argsIgnorePattern: '^_' },
     ],
 
-    // TODO - enable these new recommended rules
-    '@typescript-eslint/restrict-template-expressions': 'off',
     // TODO - enable this
     '@typescript-eslint/naming-convention': 'off',
 
diff --git a/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts b/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts
@@ -144,7 +144,7 @@ export default createRule({
             missingBranches: missingBranchTypes
               .map(missingType =>
                 isTypeFlagSet(missingType, ts.TypeFlags.ESSymbolLike)
-                  ? `typeof ${missingType.getSymbol()?.escapedName}`
+                  ? `typeof ${missingType.getSymbol()?.escapedName as string}`
                   : checker.typeToString(missingType),
               )
               .join(' | '),
diff --git a/packages/scope-manager/tests/fixtures.test.ts b/packages/scope-manager/tests/fixtures.test.ts
@@ -124,7 +124,7 @@ function nestDescribe(
           throw new Error(
             `Expected value for ${key} to be one of (${Array.from(type[1]).join(
               ' | ',
-            )}), but got ${value}`,
+            )}), but got ${value as string}`,
           );
         }
 
diff --git a/packages/scope-manager/tests/util/serializers/TSESTreeNode.ts b/packages/scope-manager/tests/util/serializers/TSESTreeNode.ts
@@ -14,6 +14,7 @@ const EXCLUDED_KEYS = new Set([
 
 const generator = createIdGenerator();
 type Node = Record<string, unknown> & { type: AST_NODE_TYPES };
+type Identifier = Node & { name: string; type: AST_NODE_TYPES.Identifier };
 const SEEN_NODES = new Map<Node, number>();
 
 const serializer: NewPlugin = {
@@ -29,7 +30,7 @@ const serializer: NewPlugin = {
   },
   serialize(node: Node): string {
     if (node.type === AST_NODE_TYPES.Identifier) {
-      return `Identifier<"${node.name}">`;
+      return `Identifier<"${(node as Identifier).name}">`;
     }
 
     const keys = Object.keys(node).filter(k => !EXCLUDED_KEYS.has(k));
diff --git a/packages/scope-manager/tests/util/serializers/baseSerializer.ts b/packages/scope-manager/tests/util/serializers/baseSerializer.ts
@@ -62,7 +62,7 @@ function createSerializer<TConstructor extends ConstructorSignature>(
         }
 
         outputLines.push(
-          `${childIndentation}${key}: ${printer(
+          `${childIndentation}${key as string}: ${printer(
             value,
             config,
             childIndentation,

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ export default createRule({`
`144`	`144`	`missingBranches: missingBranchTypes`
`145`	`145`	`.map(missingType =>`
`146`	`146`	`isTypeFlagSet(missingType, ts.TypeFlags.ESSymbolLike)`
`147`		- ? `typeof ${missingType.getSymbol()?.escapedName}`
	`147`	+ ? `typeof ${missingType.getSymbol()?.escapedName as string}`
`148`	`148`	`: checker.typeToString(missingType),`
`149`	`149`	`)`
`150`	`150`	`.join(' \| '),`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ function nestDescribe(`
`124`	`124`	`throw new Error(`
`125`	`125`	`Expected value for ${key} to be one of (${Array.from(type[1]).join(
`126`	`126`	`' \| ',`
`127`		- )}), but got ${value}`,
	`127`	+ )}), but got ${value as string}`,
`128`	`128`	`);`
`129`	`129`	`}`
`130`	`130`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ function createSerializer<TConstructor extends ConstructorSignature>(`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`outputLines.push(`
`65`		- `${childIndentation}${key}: ${printer(
	`65`	+ `${childIndentation}${key as string}: ${printer(
`66`	`66`	`value,`
`67`	`67`	`config,`
`68`	`68`	`childIndentation,`