Skip to content

Add test to verify parameters match between operator and decorator #48448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
eladkal opened this issue Mar 27, 2025 · 6 comments · May be fixed by #50741
Open
1 task done

Add test to verify parameters match between operator and decorator #48448

eladkal opened this issue Mar 27, 2025 · 6 comments · May be fixed by #50741
Assignees
@gomtangman
Labels
area:providers good first issue kind:meta High-level information important to the community provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Comments

@eladkal
Copy link
Contributor

eladkal commented Mar 27, 2025

Body

We shouldn't have notes like:

airflow/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py

Lines 236 to 237 in 6508f12

# !!! Changes in KubernetesPodOperator's arguments should be also reflected in !!!
# - airflow-core/src/airflow/decorators/__init__.pyi (by a separate PR)

this is very easy to miss both by PR author and the reviewer

The task:
Add tests to all existed decorators to make sure the parameter list they accept match to the operator.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added good first issue kind:meta High-level information important to the community labels Mar 27, 2025
@dosubot dosubot bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Mar 27, 2025
@gomtangman
Copy link
Contributor

Hi!
Can I take this issue and work on it?

@Shweta-281
Copy link

Hi [@gomtangman], I noticed you’re assigned to this issue. I’d love to contribute here too—are you open to collaboration? I’m happy to pair-program, tackle a subtask, or review your work. Let me know how I can assist!

@gomtangman
Copy link
Contributor

@Shweta-281 Thank you for your suggestion
I am writing a test now. So can you review it when I make a pull request?

@gomtangman
Copy link
Contributor

Hi @Shweta-281
I became busy doing my work to keep up with this issue.
So if you are still interested in this issue, can you work on it instead of me?
I thought it would be good to test whether the test is covering all the decorators.
So, I searched for a way to retrieve all the decorators but I failed to find one.
If you can find a way to ensure all the decorators are tested, I think that'll increase the quality of tests.

@Debasishpradhan28
Copy link

I want to take this issue and work on it. can I ?

@gomtangman
Copy link
Contributor

@Debasishpradhan28
Yes, please take it

@Shashwatpandey4 Shashwatpandey4 linked a pull request May 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gomtangman gomtangman

Labels
area:providers good first issue kind:meta High-level information important to the community provider:cncf-kubernetes Kubernetes (k8s) provider related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added test to verify decorator signature matches KubernetesPodOperator Shashwatpandey4/airflow
4 participants
@eladkal @gomtangman @Shweta-281 @Debasishpradhan28
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy