fix(eslint-plugin): [explicit-function-return-type] Fix obj setter prop

bradzacher · bradzacher · commit 8c8497ce2f1c · 2019-05-13T14:06:04.000-07:00
Fixes typescript-eslint#525
diff --git a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts
@@ -65,7 +65,8 @@ export default util.createRule<Options, MessageIds>({
     function isSetter(node: TSESTree.Node | undefined): boolean {
       return (
         !!node &&
-        node.type === AST_NODE_TYPES.MethodDefinition &&
+        (node.type === AST_NODE_TYPES.MethodDefinition ||
+          node.type === AST_NODE_TYPES.Property) &&
         node.kind === 'set'
       );
     }
diff --git a/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts b/packages/eslint-plugin/tests/rules/explicit-function-return-type.test.ts
@@ -169,6 +169,17 @@ class App {
       `,
       options: [{ allowTypedFunctionExpressions: true }],
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/525
+    {
+      filename: 'test.ts',
+      code: `
+const myObj = {
+  set myProp(val) {
+    this.myProp = val;
+  },
+};
+      `,
+    },
   ],
   invalid: [
     {
diff --git a/packages/typescript-estree/src/ts-estree/ts-estree.ts b/packages/typescript-estree/src/ts-estree/ts-estree.ts
@@ -895,7 +895,7 @@ export interface Property extends BaseNode {
   computed: boolean;
   method: boolean;
   shorthand: boolean;
-  kind: 'init';
+  kind: 'init' | 'get' | 'set';
 }
 
 export interface RestElement extends BaseNode {

Original file line number	Diff line number	Diff line change
`@@ -895,7 +895,7 @@ export interface Property extends BaseNode {`
`895`	`895`	`computed: boolean;`
`896`	`896`	`method: boolean;`
`897`	`897`	`shorthand: boolean;`
`898`		`- kind: 'init';`
	`898`	`+ kind: 'init' \| 'get' \| 'set';`
`899`	`899`	`}`
`900`	`900`
`901`	`901`	`export interface RestElement extends BaseNode {`