fix(eslint-plugin): [no-restricted-imports] fix crash when no options given (typescript-eslint#3947)

rafaelss95 · web-flow · commit edaa3c10eb67 · 2021-10-03T14:58:11.000-07:00
diff --git a/packages/eslint-plugin/src/rules/no-restricted-imports.ts b/packages/eslint-plugin/src/rules/no-restricted-imports.ts
@@ -1,14 +1,14 @@
 import { AST_NODE_TYPES } from '@typescript-eslint/experimental-utils';
 import baseRule, {
-  ArrayOfStringOrObjectPatterns,
   ArrayOfStringOrObject,
+  ArrayOfStringOrObjectPatterns,
 } from 'eslint/lib/rules/no-restricted-imports';
 import ignore, { Ignore } from 'ignore';
 import {
-  InferOptionsTypeFromRule,
-  InferMessageIdsTypeFromRule,
   createRule,
   deepMerge,
+  InferMessageIdsTypeFromRule,
+  InferOptionsTypeFromRule,
 } from '../util';
 
 export type Options = InferOptionsTypeFromRule<typeof baseRule>;
@@ -119,6 +119,10 @@ export default createRule<Options, MessageIds>({
     const rules = baseRule.create(context);
     const { options } = context;
 
+    if (options.length === 0) {
+      return {};
+    }
+
     const restrictedPaths = getRestrictedPaths(options);
     const allowedTypeImportPathNameSet: Set<string> = new Set();
     for (const restrictedPath of restrictedPaths) {
diff --git a/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts b/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts
@@ -8,6 +8,7 @@ const ruleTester = new RuleTester({
 
 ruleTester.run('no-restricted-imports', rule, {
   valid: [
+    "import foo from 'foo';",
     {
       code: "import foo from 'foo';",
       options: ['import1', 'import2'],

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ const ruleTester = new RuleTester({`
`8`	`8`
`9`	`9`	`ruleTester.run('no-restricted-imports', rule, {`
`10`	`10`	`valid: [`
	`11`	`+ "import foo from 'foo';",`
`11`	`12`	`{`
`12`	`13`	`code: "import foo from 'foo';",`
`13`	`14`	`options: ['import1', 'import2'],`