test(eslint-plugin): add missing test cases for rules (typescript-eslint#296)

armano2 · web-flow · commit fa0b032340e2 · 2019-02-19T02:47:27.000+01:00
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts b/packages/eslint-plugin/src/rules/no-unnecessary-qualifier.ts
@@ -90,8 +90,6 @@ export default util.createRule({
       const tsQualifier = esTreeNodeToTSNodeMap.get(qualifier);
       const tsName = esTreeNodeToTSNodeMap.get(name);
 
-      if (!(tsQualifier && tsName)) return false; // TODO: throw error?
-
       const namespaceSymbol = checker.getSymbolAtLocation(tsQualifier);
 
       if (
@@ -145,16 +143,11 @@ export default util.createRule({
     }
 
     function enterDeclaration(node: TSESTree.Node): void {
-      const tsDeclaration = esTreeNodeToTSNodeMap.get(node);
-      if (tsDeclaration) {
-        namespacesInScope.push(tsDeclaration);
-      }
+      namespacesInScope.push(esTreeNodeToTSNodeMap.get(node));
     }
 
-    function exitDeclaration(node: TSESTree.Node) {
-      if (esTreeNodeToTSNodeMap.has(node)) {
-        namespacesInScope.pop();
-      }
+    function exitDeclaration() {
+      namespacesInScope.pop();
     }
 
     function resetCurrentNamespaceExpression(node: TSESTree.Node): void {
diff --git a/packages/eslint-plugin/tests/rules/array-type.test.ts b/packages/eslint-plugin/tests/rules/array-type.test.ts
@@ -40,6 +40,10 @@ ruleTester.run('array-type', rule, {
       code: 'let a: Array<{ foo: Array<Bar> }> = []',
       options: ['generic']
     },
+    {
+      code: `let fooVar: Array;`,
+      options: ['generic']
+    },
     {
       code: `function foo (a: Array<Bar>): Array<Bar> {}`,
       options: ['generic']
@@ -622,6 +626,30 @@ let yyyy: Arr<Arr<string>[][]> = [[[["2"]]]];`,
         }
       ]
     },
+    {
+      code: `let fooVar: Array[];`,
+      options: ['array'],
+      errors: [
+        {
+          messageId: 'errorStringArray',
+          data: { type: 'any' },
+          line: 1,
+          column: 13
+        }
+      ]
+    },
+    {
+      code: `let fooVar: Array[];`,
+      options: ['array-simple'],
+      errors: [
+        {
+          messageId: 'errorStringArraySimple',
+          data: { type: 'any' },
+          line: 1,
+          column: 13
+        }
+      ]
+    },
     {
       code: `let x: Array<number> = [1] as number[];`,
       output: `let x: Array<number> = [1] as Array<number>;`,
diff --git a/packages/eslint-plugin/tests/rules/type-annotation-spacing.test.ts b/packages/eslint-plugin/tests/rules/type-annotation-spacing.test.ts
@@ -84,6 +84,10 @@ type Foo = {
     greet: (name: string) => string;
 }
         `,
+    `
+const isString = (): x is string => {
+}
+    `,
     {
       code: 'let foo: string;',
       options: [{ after: true }]

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,10 @@ type Foo = {`
`84`	`84`	`greet: (name: string) => string;`
`85`	`85`	`}`
`86`	`86`	`,
	`87`	+ `
	`88`	`+const isString = (): x is string => {`
	`89`	`+}`
	`90`	+ `,
`87`	`91`	`{`
`88`	`92`	`code: 'let foo: string;',`
`89`	`93`	`options: [{ after: true }]`