test(eslint-plugin): add missing tests for no-type-alias and no-parameter-properties (typescript-eslint#274)

armano2 · bradzacher · commit 8d741f47e615 · 2019-02-14T09:49:57.000-08:00
* test(eslint-plugin): add test for no-type-alias

* test(eslint-plugin): add test cases no-parameter-properties

* test(eslint-plugin): fix test case

Co-Authored-By: armano2 &lt;armano2@users.noreply.github.com&gt;
diff --git a/packages/eslint-plugin/tests/rules/no-parameter-properties.test.ts b/packages/eslint-plugin/tests/rules/no-parameter-properties.test.ts
@@ -13,6 +13,11 @@ class Foo {
 }
         `,
     `
+class Foo {
+    constructor(...name: string[]) {}
+}
+        `,
+    `
 class Foo {
     constructor(name: string, age: number) {}
 }
@@ -94,7 +99,19 @@ class Foo {
 }
             `,
       options: [{ allows: ['public readonly', 'private'] }]
-    }
+    },
+    // Semantically invalid test case
+    `
+class Foo {
+    constructor(private ...name: string[]) {}
+}
+    `,
+    // Semantically invalid test case
+    `
+class Foo {
+    constructor(private [test]: [string]) {}
+}
+    `
   ],
   invalid: [
     {
diff --git a/packages/eslint-plugin/tests/rules/no-type-alias.test.ts b/packages/eslint-plugin/tests/rules/no-type-alias.test.ts
@@ -2888,6 +2888,20 @@ type Foo<T> = {
           column: 5
         }
       ]
+    },
+    {
+      // https://github.com/typescript-eslint/typescript-eslint/issues/270
+      code: `export type ButtonProps = JSX.IntrinsicElements['button'];`,
+      errors: [
+        {
+          messageId: 'noTypeAlias',
+          data: {
+            alias: 'aliases'
+          },
+          line: 1,
+          column: 27
+        }
+      ]
     }
   ]
 });

Original file line number	Diff line number	Diff line change
`@@ -2888,6 +2888,20 @@ type Foo<T> = {`
`2888`	`2888`	`column: 5`
`2889`	`2889`	`}`
`2890`	`2890`	`]`
	`2891`	`+ },`
	`2892`	`+ {`
	`2893`	`+ // https://github.com/typescript-eslint/typescript-eslint/issues/270`
	`2894`	+ code: `export type ButtonProps = JSX.IntrinsicElements['button'];`,
	`2895`	`+ errors: [`
	`2896`	`+ {`
	`2897`	`+ messageId: 'noTypeAlias',`
	`2898`	`+ data: {`
	`2899`	`+ alias: 'aliases'`
	`2900`	`+ },`
	`2901`	`+ line: 1,`
	`2902`	`+ column: 27`
	`2903`	`+ }`
	`2904`	`+ ]`
`2891`	`2905`	`}`
`2892`	`2906`	`]`
`2893`	`2907`	`});`