feat: FirestoreRecordManager #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
d3ba6ed to
90db9cd
Compare
90db9cd to
91ed0b7
Compare
0065cd6 to
deb6f5f
Compare
|
Thank you for the PR. I will review within a couple days. |
averikitsch
requested changes
Sep 11, 2024
| pass | ||
|
|
||
| def get_time(self) -> datetime.datetime: | ||
| return datetime.datetime.now(datetime.timezone.utc) |
There was a problem hiding this comment.
@JU-2094 should this use the server timestamp, firestore.SERVER_TIMESTAMP?
| time_at_least: Optional[float] = None, | ||
| ) -> Dict[str, int]: | ||
| logger.info("Calling synchronous update method") | ||
| return self.update(keys, group_ids=group_ids, time_at_least=time_at_least) |
There was a problem hiding this comment.
Please use the async client for all async methods
| return result | ||
|
|
||
| async def aexists(self, keys: Sequence[str]) -> List[bool]: | ||
| logger.info("Calling synchronous exists method") |
There was a problem hiding this comment.
Suggested change
| logger.info("Calling synchronous exists method") | |
| logger.info("Calling asynchronous exists method") |
averikitsch
reviewed
Sep 11, 2024
| from google.cloud import firestore | ||
| from langchain_google_firestore import FirestoreRecordManager | ||
|
|
||
| @pytest.fixture(scope="module") |
There was a problem hiding this comment.
Thank you for the tests. Can you provide a few integration tests?
averikitsch
reviewed
Sep 11, 2024
|
/gcbrun |
|
any updates on this implementation?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A record manager for Langchain Indexing based on the Langchain RecordManager Base Class as a Firestore alternative to the SQLRecordManager
Fixes #89 🦕