Fix location of --push directive for prod images (#22142)

potiuk · web-flow · commit 57e711e8496d · 2022-03-10T11:59:07.000+01:00
Previous #22127 had `--push` added in a wrong place. It should only be added when cache is being built and it was added always, with resulted in authentication error as login has not been performed before the --push.
diff --git a/scripts/ci/libraries/_build_images.sh b/scripts/ci/libraries/_build_images.sh
@@ -601,7 +601,6 @@ function build_images::build_prod_images() {
     elif [[ "${DOCKER_CACHE}" == "pulled" ]]; then
         docker_prod_directive=(
             "--cache-from=${AIRFLOW_PROD_IMAGE}:cache"
-            "--push"
         )
     else
         echo
@@ -616,6 +615,7 @@ function build_images::build_prod_images() {
         # Cache for prod image contains also build stage for buildx when mode=max specified!
         docker_prod_directive+=(
             "--cache-to=type=registry,ref=${AIRFLOW_PROD_IMAGE}:cache,mode=max"
+            "--push"
         )
         if [[ ${PLATFORM} =~ .*,.* ]]; then
             echo
