Content-Length: 253574 | pFad | https://redirect.github.com/i18next/i18next/issues/2311

4D1 Ensure `nsSeparator` is respected when `appendNamespaceToMissingKey` is `true` by ngrushkovsky · Pull Request #2311 · i18next/i18next · GitHub
Skip to content

Ensure nsSeparator is respected when appendNamespaceToMissingKey is true #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Ensure nsSeparator is respected when appendNamespaceToMissingKey is true #2311

merged 1 commit into from
May 14, 2025

Conversation

ngrushkovsky
Copy link
Contributor

Fixes #2310.

I tried to make the nsSeparator checks consistent with the ones in extractFromKey.

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

coverage: 95.208% (+0.01%) from 95.195%
when pulling 2bbf131 on ngrushkovsky:fix/missing-key-ns-separator
into 32979d8 on i18next:master.

@adrai adrai merged commit f50472f into i18next:master May 14, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect nsSeparator when appendNamespaceToMissingKey is true
3 participants
@ngrushkovsky @coveralls @adrai








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://redirect.github.com/i18next/i18next/issues/2311

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy