feat: convert no-array-constructor suggestions to autofixes #19621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
added
the
evaluating
nzakas
reviewed
Apr 15, 2025
mdjermanovic
added
accepted
snitin315
reviewed
Apr 18, 2025
|
I think we can simplify function hasCommentsInArrayConstructor(node) {
const firstToken = sourceCode.getFirstToken(node);
const lastToken = sourceCode.getLastToken(node);
let lastRelevantToken = sourceCode.getLastToken(node.callee);
while (
lastRelevantToken !== lastToken &&
!isOpeningParenToken(lastRelevantToken)
) {
lastRelevantToken = sourceCode.getTokenAfter(lastRelevantToken);
}
return sourceCode.commentsExistBetween(
firstToken,
lastRelevantToken
);
} |
mdjermanovic
previously approved these changes
May 2, 2025
There was a problem hiding this comment.
LGTM, thanks! Leaving open for @nzakas and @snitin315 to verify their review comments.
nzakas
reviewed
May 2, 2025
nzakas
previously approved these changes
May 6, 2025
mdjermanovic
requested changes
May 6, 2025
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Array(...args)as we can't know ifargsmight have only one element.Is there anything you'd like reviewers to focus on?
Closes #19608