lib: remove redundant global regexps

gurgunday · aduh95 · commit f10239fde781 · 2024-12-10T20:30:59.000+01:00
PR-URL: #56182 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/internal/util/debuglog.js b/lib/internal/util/debuglog.js
@@ -173,7 +173,7 @@ function formatTime(ms) {
 }
 
 function safeTraceLabel(label) {
-  return label.replace(/\\/g, '\\\\').replaceAll('"', '\\"');
+  return label.replaceAll('\\', '\\\\').replaceAll('"', '\\"');
 }
 
 /**
diff --git a/lib/url.js b/lib/url.js
@@ -705,7 +705,7 @@ Url.prototype.format = function format() {
     }
   }
 
-  search = search.replace(/#/g, '%23');
+  search = search.replaceAll('#', '%23');
 
   if (hash && hash.charCodeAt(0) !== CHAR_HASH)
     hash = '#' + hash;

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ function formatTime(ms) {`
`173`	`173`	`}`
`174`	`174`
`175`	`175`	`function safeTraceLabel(label) {`
`176`		`- return label.replace(/\\/g, '\\\\').replaceAll('"', '\\"');`
	`176`	`+ return label.replaceAll('\\', '\\\\').replaceAll('"', '\\"');`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -705,7 +705,7 @@ Url.prototype.format = function format() {`
`705`	`705`	`}`
`706`	`706`	`}`
`707`	`707`
`708`		`- search = search.replace(/#/g, '%23');`
	`708`	`+ search = search.replaceAll('#', '%23');`
`709`	`709`
`710`	`710`	`if (hash && hash.charCodeAt(0) !== CHAR_HASH)`
`711`	`711`	`hash = '#' + hash;`