test: fix race condition in test-child-process-bad-stdio

cjihrig · targos · commit 7c9fa11127e6 · 2025-02-05T10:35:23.000+01:00
test-child-process-bad-stdio.js contains a race condition between a timeout in the test process and a timeout in the spawned child process. This commit addresses the race condition by having the child process wait indefinitely to be killed. PR-URL: #56845 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
diff --git a/test/parallel/test-child-process-bad-stdio.js b/test/parallel/test-child-process-bad-stdio.js
@@ -3,7 +3,7 @@
 const common = require('../common');
 
 if (process.argv[2] === 'child') {
-  setTimeout(() => {}, common.platformTimeout(100));
+  setTimeout(() => {}, common.platformTimeout(1000));
   return;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`const common = require('../common');`
`4`	`4`
`5`	`5`	`if (process.argv[2] === 'child') {`
`6`		`- setTimeout(() => {}, common.platformTimeout(100));`
	`6`	`+ setTimeout(() => {}, common.platformTimeout(1000));`
`7`	`7`	`return;`
`8`	`8`	`}`
`9`	`9`