Content-Length: 321046 | pFad | https://github.com/kubernetes/kubernetes/issues/103476

60 Fix TerminationGracePeriodSeconds is negative · Issue #103476 · kubernetes/kubernetes · GitHub
Skip to content

Fix TerminationGracePeriodSeconds is negative #103476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 of 3 tasks
wzshiming opened this issue Jul 5, 2021 · 8 comments
Closed
2 of 3 tasks

Fix TerminationGracePeriodSeconds is negative #103476

wzshiming opened this issue Jul 5, 2021 · 8 comments
Assignees
@wzshiming
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@wzshiming
Copy link
Member

wzshiming commented Jul 5, 2021 •
edited by liggitt
Loading

  • Firstly release 1.22 Fix TerminationGracePeriodSeconds is negative (part 1) #98866:
    • Treat negative as 1 in delete path (pod/strategy.go, apiserver delete.go)
    • Allow delete with grace period 0 even if metadata period is negative (apiserver delete.go). This allows kubelet to delete pods.
    • Relax validation of immutable fields to allow it to be set to 1 if it was previously negative. This allows us to update read path in the next release. All consumers would also need to be able to handle this change in a sane manner.
  • Secondly release 1.27 pod.spec.terminationGracePeriodSeconds is a negative then convert to 1 #115606:
    • Treat negative as 1 (defaulting or conversion)
  • Thirdly:
    • Returning an error on Pod create could break things like Deployment updates. But if we update defaulting, then I think we won't hit this issue.

What would you like to be added:

#98866 (comment)

Why is this needed:
@wzshiming wzshiming added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 5, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 5, 2021
@wzshiming
Copy link
Member Author

/assign

@wzshiming
Copy link
Member Author

/sig node
/triage accepted
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 5, 2021
@wzshiming wzshiming mentioned this issue Jul 5, 2021
Merged
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 8, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wzshiming wzshiming mentioned this issue Feb 8, 2023
Merged
@liggitt
Copy link
Member

liggitt commented May 9, 2025

We now warn when this field is negative, and treat it like 1. I don't think we're going to start rejecting requests. Is this as complete as we can make it?

@wzshiming
Copy link
Member Author

Yeah, we can only do so much more if we don't start rejecting requests.

@liggitt
Copy link
Member

liggitt commented May 13, 2025

I think warning and treating as 1 is a reasonable point at which to end this improvement.

@wzshiming
Copy link
Member Author

make sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wzshiming wzshiming

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liggitt @wzshiming @k8s-ci-robot @k8s-triage-robot








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/kubernetes/kubernetes/issues/103476

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy