chore(samples): Snippet Generating Script: part 2 - moving the snippets to new format #225

m-strzelczyk · 2022-02-24T17:03:26Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

BEGIN_COMMIT_OVERRIDE
docs(samples): additional samples for the Compute API
END_COMMIT_OVERRIDE

Preparing the SGS (Snippet Generating System) script to handle the burden of duplicated code in the samples.

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…o sgs-take-2

snippet-bot · 2022-02-24T17:04:12Z

You are about to delete the following sample browser pages.

samples/snippets/sample_firewall.py:19, tag compute_firewall_create(usage: page 1).
samples/snippets/sample_firewall.py:21, tag compute_firewall_delete(usage: page 1).
samples/snippets/sample_firewall.py:59, tag compute_firewall_create(usage: page 1).
samples/snippets/sample_firewall.py:139, tag compute_firewall_delete(usage: page 1).
samples/snippets/sample_pagination.py:18, tag compute_images_list(usage: page 1).
samples/snippets/sample_pagination.py:25, tag compute_images_list(usage: page 1).
samples/snippets/sample_instance_from_template.py:15, tag compute_instances_create_from_template(usage: page 1).
samples/snippets/sample_instance_from_template.py:16, tag compute_instances_create_from_template_with_overrides(usage: page 1).
samples/snippets/sample_instance_from_template.py:60, tag compute_instances_create_from_template_with_overrides(usage: page 1).
samples/snippets/quickstart.py:22, tag compute_instances_create(usage: page 1).
samples/snippets/quickstart.py:23, tag compute_instances_delete(usage: page 1).
samples/snippets/quickstart.py:28, tag compute_instances_list_all(usage: page 1).
samples/snippets/quickstart.py:29, tag compute_instances_operation_check(usage: page 1).
samples/snippets/quickstart.py:65, tag compute_instances_list_all(usage: page 1).
samples/snippets/quickstart.py:101, tag compute_instances_create(usage: page 1).
samples/snippets/quickstart.py:183, tag compute_instances_delete(usage: page 1).
samples/snippets/quickstart.py:215, tag compute_instances_operation_check(usage: page 1).
samples/snippets/sample_start_stop.py:21, tag compute_start_instance(usage: page 1).
samples/snippets/sample_start_stop.py:22, tag compute_start_enc_instance(usage: page 1).
samples/snippets/sample_start_stop.py:23, tag compute_stop_instance(usage: page 1).
samples/snippets/sample_start_stop.py:24, tag compute_reset_instance(usage: page 1).
samples/snippets/sample_start_stop.py:33, tag compute_start_instance(usage: page 1).
samples/snippets/sample_start_stop.py:58, tag compute_start_enc_instance(usage: page 1).
samples/snippets/sample_start_stop.py:105, tag compute_stop_instance(usage: page 1).
samples/snippets/sample_start_stop.py:130, tag compute_reset_instance(usage: page 1).

Here is the summary of changes.

You are about to add 56 region tags.

samples/snippets/firewall/create.py:22, tag compute_firewall_create
samples/snippets/firewall/delete.py:22, tag compute_firewall_delete
samples/snippets/firewall/list.py:22, tag compute_firewall_list
samples/snippets/firewall/patch.py:22, tag compute_firewall_patch
samples/snippets/images/get.py:22, tag compute_images_get_from_family
samples/snippets/images/get.py:23, tag compute_images_get
samples/snippets/images/get.py:39, tag compute_images_get
samples/snippets/images/list.py:22, tag compute_images_get_list
samples/snippets/images/pagination.py:23, tag compute_images_list_page
samples/snippets/images/pagination.py:24, tag compute_images_list
samples/snippets/images/pagination.py:31, tag compute_images_list
samples/snippets/images/pagination.py:61, tag compute_images_list_page
samples/snippets/instance_templates/create.py:22, tag compute_template_create
samples/snippets/instance_templates/create_from_instance.py:22, tag compute_template_create_from_instance
samples/snippets/instance_templates/create_with_subnet.py:22, tag compute_template_create_with_subnet
samples/snippets/instance_templates/delete.py:22, tag compute_template_delete
samples/snippets/instance_templates/get.py:22, tag compute_template_get
samples/snippets/instance_templates/list.py:22, tag compute_template_list
samples/snippets/instances/create.py:22, tag compute_instances_create
samples/snippets/instances/create_start_instance/create_from_custom_image.py:22, tag compute_instances_create_from_custom_image
samples/snippets/instances/create_start_instance/create_from_public_image.py:22, tag compute_instances_create_from_image
samples/snippets/instances/create_start_instance/create_from_snapshot.py:22, tag compute_instances_create_from_snapshot
samples/snippets/instances/create_start_instance/create_with_additional_disk.py:22, tag compute_instances_create_from_image_plus_empty_disk
samples/snippets/instances/create_start_instance/create_with_snapshotted_data_disk.py:22, tag compute_instances_create_from_image_plus_snapshot_disk
samples/snippets/instances/create_with_subnet.py:22, tag compute_instances_create_with_subnet
samples/snippets/instances/custom_hostname/create.py:22, tag compute_instances_create_custom_hostname
samples/snippets/instances/custom_hostname/get.py:22, tag compute_instances_get_hostname
samples/snippets/instances/custom_machine_types/create_shared_with_helper.py:22, tag compute_custom_machine_type_create_shared_with_helper
samples/snippets/instances/custom_machine_types/create_with_helper.py:22, tag compute_custom_machine_type_create_with_helper
samples/snippets/instances/custom_machine_types/create_without_helper.py:22, tag compute_custom_machine_type_create_without_helper
samples/snippets/instances/custom_machine_types/extra_mem_no_helper.py:22, tag compute_custom_machine_type_extra_mem_no_helper
samples/snippets/instances/custom_machine_types/helper_class.py:22, tag compute_custom_machine_type_helper_class
samples/snippets/instances/custom_machine_types/update_memory.py:22, tag compute_custom_machine_type_update_memory
samples/snippets/instances/delete.py:22, tag compute_instances_delete
samples/snippets/instances/delete_protection/create.py:22, tag compute_delete_protection_create
samples/snippets/instances/delete_protection/get.py:22, tag compute_delete_protection_get
samples/snippets/instances/delete_protection/set.py:22, tag compute_delete_protection_set
samples/snippets/instances/from_instance_template/create_from_template.py:22, tag compute_instances_create_from_template
samples/snippets/instances/from_instance_template/create_from_template_with_overrides.py:22, tag compute_instances_create_from_template_with_overrides
samples/snippets/instances/list.py:22, tag compute_instances_list
samples/snippets/instances/list_all.py:22, tag compute_instances_list_all
samples/snippets/instances/preemptible/create_preemptible.py:22, tag compute_preemptible_create
samples/snippets/instances/preemptible/is_preemptible.py:22, tag compute_preemptible_check
samples/snippets/instances/preemptible/preemption_history.py:22, tag compute_preemptible_history
samples/snippets/instances/reset.py:22, tag compute_reset_instance
samples/snippets/instances/start.py:22, tag compute_start_instance
samples/snippets/instances/start_encrypted.py:22, tag compute_start_enc_instance
samples/snippets/instances/stop.py:22, tag compute_stop_instance
samples/snippets/operations/operation_check.py:35, tag compute_instances_operation_check
samples/snippets/usage_report/usage_reports.py:25, tag compute_instances_verify_default_value
samples/snippets/usage_report/usage_reports.py:26, tag compute_usage_report_set
samples/snippets/usage_report/usage_reports.py:27, tag compute_usage_report_get
samples/snippets/usage_report/usage_reports.py:28, tag compute_usage_report_disable
samples/snippets/usage_report/usage_reports.py:37, tag compute_usage_report_set
samples/snippets/usage_report/usage_reports.py:79, tag compute_usage_report_get
samples/snippets/usage_report/usage_reports.py:117, tag compute_usage_report_disable

You are about to delete 112 region tags.

samples/snippets/sample_images.py:17, tag compute_images_get
samples/snippets/sample_images.py:18, tag compute_images_get_list
samples/snippets/sample_images.py:25, tag compute_images_get_list
samples/snippets/sample_images.py:43, tag compute_images_get
samples/snippets/sample_firewall.py:18, tag compute_firewall_list
samples/snippets/sample_firewall.py:19, tag compute_firewall_create
samples/snippets/sample_firewall.py:20, tag compute_firewall_patch
samples/snippets/sample_firewall.py:21, tag compute_firewall_delete
samples/snippets/sample_firewall.py:30, tag compute_firewall_list
samples/snippets/sample_firewall.py:59, tag compute_firewall_create
samples/snippets/sample_firewall.py:111, tag compute_firewall_patch
samples/snippets/sample_firewall.py:139, tag compute_firewall_delete
samples/snippets/sample_pagination.py:17, tag compute_images_list_page
samples/snippets/sample_pagination.py:18, tag compute_images_list
samples/snippets/sample_pagination.py:25, tag compute_images_list
samples/snippets/sample_pagination.py:52, tag compute_images_list_page
samples/snippets/sample_custom_types.py:14, tag compute_custom_machine_type_create
samples/snippets/sample_custom_types.py:27, tag compute_custom_machine_type_helper_class
samples/snippets/sample_custom_types.py:212, tag compute_custom_machine_type_create
samples/snippets/sample_custom_types.py:288, tag compute_custom_machine_type_create_with_helper
samples/snippets/sample_custom_types.py:325, tag compute_custom_machine_type_create_shared_with_helper
samples/snippets/sample_custom_types.py:359, tag compute_custom_machine_type_create_without_helper
samples/snippets/sample_custom_types.py:427, tag compute_custom_machine_type_extra_mem_no_helper
samples/snippets/sample_custom_types.py:471, tag compute_custom_machine_type_update_memory
samples/snippets/sample_instance_from_template.py:15, tag compute_instances_create_from_template
samples/snippets/sample_instance_from_template.py:16, tag compute_instances_create_from_template_with_overrides
samples/snippets/sample_instance_from_template.py:60, tag compute_instances_create_from_template_with_overrides
samples/snippets/quickstart.py:22, tag compute_instances_create
samples/snippets/quickstart.py:23, tag compute_instances_delete
samples/snippets/quickstart.py:27, tag compute_instances_list
samples/snippets/quickstart.py:28, tag compute_instances_list_all
samples/snippets/quickstart.py:29, tag compute_instances_operation_check
samples/snippets/quickstart.py:41, tag compute_instances_list
samples/snippets/quickstart.py:65, tag compute_instances_list_all
samples/snippets/quickstart.py:101, tag compute_instances_create
samples/snippets/quickstart.py:183, tag compute_instances_delete
samples/snippets/quickstart.py:215, tag compute_instances_operation_check
samples/snippets/sample_create_vm.py:18, tag compute_instances_create_with_subnet
samples/snippets/sample_create_vm.py:19, tag compute_instances_create_from_image_plus_snapshot_disk
samples/snippets/sample_create_vm.py:20, tag compute_instances_create_from_snapshot
samples/snippets/sample_create_vm.py:21, tag compute_instances_create_from_image_plus_empty_disk
samples/snippets/sample_create_vm.py:22, tag compute_instances_create_from_custom_image
samples/snippets/sample_create_vm.py:23, tag compute_instances_create_from_image
samples/snippets/sample_create_vm.py:35, tag compute_instances_create_with_subnet
samples/snippets/sample_create_vm.py:36, tag compute_instances_create_from_image_plus_snapshot_disk
samples/snippets/sample_create_vm.py:37, tag compute_instances_create_from_image_plus_empty_disk
samples/snippets/sample_create_vm.py:38, tag compute_instances_create_from_custom_image
samples/snippets/sample_create_vm.py:39, tag compute_instances_create_from_image
samples/snippets/sample_create_vm.py:80, tag compute_instances_create_from_image_plus_empty_disk
samples/snippets/sample_create_vm.py:110, tag compute_instances_create_from_image_plus_snapshot_disk
samples/snippets/sample_create_vm.py:111, tag compute_instances_create_from_snapshot
samples/snippets/sample_create_vm.py:148, tag compute_instances_create_with_subnet
samples/snippets/sample_create_vm.py:149, tag compute_instances_create_from_image_plus_snapshot_disk
samples/snippets/sample_create_vm.py:150, tag compute_instances_create_from_snapshot
samples/snippets/sample_create_vm.py:151, tag compute_instances_create_from_image_plus_empty_disk
samples/snippets/sample_create_vm.py:152, tag compute_instances_create_from_custom_image
samples/snippets/sample_create_vm.py:153, tag compute_instances_create_from_image
samples/snippets/sample_create_vm.py:240, tag compute_instances_create_from_image
samples/snippets/sample_create_vm.py:267, tag compute_instances_create_from_custom_image
samples/snippets/sample_create_vm.py:293, tag compute_instances_create_from_image_plus_empty_disk
samples/snippets/sample_create_vm.py:324, tag compute_instances_create_from_snapshot
samples/snippets/sample_create_vm.py:350, tag compute_instances_create_from_image_plus_snapshot_disk
samples/snippets/sample_create_vm.py:384, tag compute_instances_create_with_subnet
samples/snippets/sample_custom_hostname.py:15, tag compute_instances_create_custom_hostname
samples/snippets/sample_custom_hostname.py:19, tag compute_instances_get_hostname
samples/snippets/sample_custom_hostname.py:26, tag compute_instances_create_custom_hostname
samples/snippets/sample_custom_hostname.py:98, tag compute_instances_get_hostname
samples/snippets/sample_delete_protection.py:14, tag compute_delete_protection_create
samples/snippets/sample_delete_protection.py:19, tag compute_delete_protection_get
samples/snippets/sample_delete_protection.py:20, tag compute_delete_protection_set
samples/snippets/sample_delete_protection.py:21, tag compute_delete_protection_create
samples/snippets/sample_delete_protection.py:29, tag compute_delete_protection_create
samples/snippets/sample_delete_protection.py:98, tag compute_delete_protection_set
samples/snippets/sample_delete_protection.py:128, tag compute_delete_protection_get
samples/snippets/sample_preemptible.py:14, tag compute_preemptible_history
samples/snippets/sample_preemptible.py:18, tag compute_preemptible_create
samples/snippets/sample_preemptible.py:23, tag compute_preemptible_history
samples/snippets/sample_preemptible.py:28, tag compute_preemptible_create
samples/snippets/sample_preemptible.py:29, tag compute_preemptible_check
samples/snippets/sample_preemptible.py:30, tag compute_preemptible_history
samples/snippets/sample_preemptible.py:37, tag compute_preemptible_history
samples/snippets/sample_preemptible.py:43, tag compute_preemptible_create
samples/snippets/sample_preemptible.py:111, tag compute_preemptible_check
samples/snippets/sample_preemptible.py:133, tag compute_preemptible_history
samples/snippets/sample_start_stop.py:21, tag compute_start_instance
samples/snippets/sample_start_stop.py:22, tag compute_start_enc_instance
samples/snippets/sample_start_stop.py:23, tag compute_stop_instance
samples/snippets/sample_start_stop.py:24, tag compute_reset_instance
samples/snippets/sample_start_stop.py:33, tag compute_start_instance
samples/snippets/sample_start_stop.py:58, tag compute_start_enc_instance
samples/snippets/sample_start_stop.py:105, tag compute_stop_instance
samples/snippets/sample_start_stop.py:130, tag compute_reset_instance
samples/snippets/sample_templates.py:15, tag compute_template_list
samples/snippets/sample_templates.py:20, tag compute_template_create
samples/snippets/sample_templates.py:21, tag compute_template_list
samples/snippets/sample_templates.py:22, tag compute_template_get
samples/snippets/sample_templates.py:23, tag compute_template_create_from_instance
samples/snippets/sample_templates.py:24, tag compute_template_create_with_subnet
samples/snippets/sample_templates.py:25, tag compute_template_delete
samples/snippets/sample_templates.py:36, tag compute_template_get
samples/snippets/sample_templates.py:58, tag compute_template_list
samples/snippets/sample_templates.py:76, tag compute_template_create
samples/snippets/sample_templates.py:132, tag compute_template_create_from_instance
samples/snippets/sample_templates.py:178, tag compute_template_create_with_subnet
samples/snippets/sample_templates.py:233, tag compute_template_delete
samples/snippets/sample_default_values.py:20, tag compute_instances_verify_default_value
samples/snippets/sample_default_values.py:21, tag compute_usage_report_set
samples/snippets/sample_default_values.py:22, tag compute_usage_report_get
samples/snippets/sample_default_values.py:23, tag compute_usage_report_disable
samples/snippets/sample_default_values.py:31, tag compute_usage_report_set
samples/snippets/sample_default_values.py:74, tag compute_usage_report_get
samples/snippets/sample_default_values.py:112, tag compute_usage_report_disable

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…o sgs-take-2

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

parthea

added minor nits, otherwise LGTM

samples/ingredients/disks/disk_from_snapshot.py

samples/ingredients/disks/empty_disk.py

samples/ingredients/firewall/delete.py

samples/ingredients/disks/disk_from_snapshot.py

samples/ingredients/firewall/get.py

samples/snippets/firewall/delete.py

samples/snippets/firewall/patch.py

samples/snippets/instances/create.py

samples/snippets/instances/custom_machine_types/create_with_helper.py

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…o sgs-take-2

parthea

LGTM

m-strzelczyk and others added 22 commits January 19, 2022 16:27

chore(samples): Snippet Generating System

04ce9cd

Preparing the SGS (Snippet Generating System) script to handle the burden of duplicated code in the samples.

🦉 Updates from OwlBot

9de1e85

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

chore(samples): Making linter ignore the test fixtures.

8a45bfc

chore(samples): Update region tags that shouldn't be region tags.

4a5c4f6

Merge branch 'main' into sgs-take-2

f7cfbdd

Merge branch 'main' into sgs-take-2

11ce9da

chore(samples): Syntax fix for Python 3.6

680ed26

Removing the 3.8 walrus syntax

ab722b4

Fixing test requirements

5d8739a

Merge branch 'main' into sgs-take-2

774fd0b

chore(samples): Trying to make the tests work

4bb9668

Cleaning up noxfile.

39f0bc4

🦉 Updates from OwlBot post-processor

e3f933c

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Removing bonus requirements file as it confuses the system.

48a8696

Merge branch 'sgs-take-2' of github.com:googleapis/python-compute int…

78f6bb0

…o sgs-take-2

Merge branch 'main' into sgs-take-2

2d59bbd

One more try to fix tests.

22d63da

Changing README to make snippet bot happy

5fb7b21

Merge branch 'main' into sgs-take-2

52a8068

chore(samples): Changing the sampels structure to use SGS

3cd9e53

Fixing some tests.

2b35aba

Adding custom hostname files.

0f1124f

product-auto-label bot added the api: compute Issues related to the googleapis/python-compute API. label Feb 24, 2022

m-strzelczyk changed the title ~~Snippet Generating Script: part 2 - moving the snippets to new format~~ chore(samples): Snippet Generating Script: part 2 - moving the snippets to new format Feb 24, 2022

product-auto-label bot added the samples Issues that are directly related to samples. label Feb 25, 2022

m-strzelczyk and others added 4 commits February 25, 2022 16:58

Merge branch 'main' into sgs-take-2

a919dd3

Making tests work again.

4214b9f

🦉 Updates from OwlBot post-processor

aa02862

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Making lint happy.

835c0da

Merge branch 'main' into sgs-take-2

593adc1

m-strzelczyk marked this pull request as ready for review March 2, 2022 14:19

m-strzelczyk requested review from a team as code owners March 2, 2022 14:19

m-strzelczyk requested a review from parthea March 2, 2022 14:20

m-strzelczyk assigned parthea Mar 2, 2022

m-strzelczyk and others added 7 commits March 3, 2022 15:15

Merge branch 'main' into sgs-take-2

6178dc4

Making tests run faster with parallelism.

b3a0128

Merge branch 'sgs-take-2' of github.com:googleapis/python-compute int…

53b9f8d

…o sgs-take-2

🦉 Updates from OwlBot post-processor

932c8dd

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

WIP.

27b16bf

🦉 Updates from OwlBot post-processor

c2569c6

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into sgs-take-2

18ee9d2

parthea reviewed Mar 6, 2022

View reviewed changes

parthea assigned m-strzelczyk and unassigned parthea Mar 6, 2022

m-strzelczyk and others added 4 commits March 7, 2022 14:51

Merge branch 'main' into sgs-take-2

e843a27

Apply suggestions from code review

43a82a2

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Applying comments from review.

e054440

Merge branch 'sgs-take-2' of github.com:googleapis/python-compute int…

684463d

…o sgs-take-2

parthea approved these changes Mar 8, 2022

View reviewed changes

parthea merged commit 72544d9 into main Mar 8, 2022

parthea deleted the sgs-take-2 branch March 8, 2022 01:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(samples): Snippet Generating Script: part 2 - moving the snippets to new format #225

chore(samples): Snippet Generating Script: part 2 - moving the snippets to new format #225

Uh oh!

m-strzelczyk commented Feb 24, 2022 •

edited by parthea

Loading

Uh oh!

snippet-bot bot commented Feb 24, 2022 •

edited

Loading

Uh oh!

parthea left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parthea left a comment

Uh oh!

Uh oh!

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

chore(samples): Snippet Generating Script: part 2 - moving the snippets to new format #225

chore(samples): Snippet Generating Script: part 2 - moving the snippets to new format #225

Uh oh!

Conversation

m-strzelczyk commented Feb 24, 2022 • edited by parthea Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snippet-bot bot commented Feb 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parthea left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

parthea left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

m-strzelczyk commented Feb 24, 2022 •

edited by parthea

Loading

snippet-bot bot commented Feb 24, 2022 •

edited

Loading

parthea left a comment •

edited

Loading