perf: use prettyPrint=false by default #28
Conversation
This tells One Platform APIs not to use excessive whitespace in responses. For some reason, the backend defaults to prettyPrint=true and does not provide a mechanism for overriding this. In response to internal customer issue 168522192. Tested locally against `google-cloud-bigquery` system and sample tests.
google-cla
bot
added
the
cla: yes
| if query_params: | ||
| url += "?" + urlencode(query_params, doseq=True) | ||
|
|
||
| if "prettyPrint" not in query_params: |
There was a problem hiding this comment.
Trying to think of cases where this could alter requests we're not anticipating and may have issue with the prettyprint param.
- will this interfere with media uploads? Mainly thinking about the resumable upload scenario.
- will this interfere with oauth negotiation?
There was a problem hiding this comment.
We could make a pre-release and verify that the tests for other libs that depend on google-cloud-core still pass. (The pre-release can also be given to the customer to pin explicitly).
There was a problem hiding this comment.
will this interfere with media uploads? Mainly thinking about the resumable upload scenario.
Since google-resumable-media uses "requests" directly, this shouldn't affect it.
I've tested these changes locally with the BigQuery system & sample tests, which all pass and do several load jobs.
I'm trying to test locally with the Storage system tests, but seem to be missing some setup steps around their encryption-related tests.
will this interfere with oauth negotiation?
No, since google-auth uses "requests" directly. It doesn't go through this library. Even if it did, I believe they've actually moved to a One Platform API for fetching tokens now. (Guessing based on the new-ish oauth2.googleapis.com endpoint)
There was a problem hiding this comment.
Created a pre-release at #31
This tells One Platform APIs not to use excessive whitespace in
responses. For some reason, the backend defaults to prettyPrint=true and
does not provide a mechanism for overriding this.
In response to internal customer issue 168522192.
Tested locally against
google-cloud-bigquerysystem and sample tests.