refactor: move system tests into tests/system directory
#475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns more closely with the templates from synthtool.
tswast
requested review from
a team and
steffnay
and removed request for
a team
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
4 tasks
|
prerelease-deps-3.8 test failures are both in the unit tests. https://source.cloud.google.com/results/invocations/aed3c05e-366a-404e-b90a-ecb134327e41/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery%2Fpresubmit%2Fprerelease-deps-3.8/log Neither seem particularly related to pyarrow (failure due to bad nightly) or to this change. Perhaps there's some state that's being held onto when the unit tests are run in the same |
plamut
approved these changes
Jan 20, 2021
Comment on lines
+23
to
+27
| IPython = pytest.importorskip("IPython") | ||
| io = pytest.importorskip("IPython.utils.io") | ||
| pandas = pytest.importorskip("pandas") | ||
| tools = pytest.importorskip("IPython.testing.tools") | ||
| interactiveshell = pytest.importorskip("IPython.terminal.interactiveshell") |
There was a problem hiding this comment.
Nice, this is IMO more clean that those skipIf decorators. 👍
| JOB_TIMEOUT = 120 # 2 minutes | ||
| WHERE = os.path.abspath(os.path.dirname(__file__)) | ||
| JOB_TIMEOUT = 120 # 2 minute | ||
| DATA_PATH = pathlib.Path(__file__).parent.parent / "data" |
There was a problem hiding this comment.
Love these small improvements and utilizing the goodies Python 3 offers!
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
tswast
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns more closely with the templates from synthtool.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #366