chore: start tracking obsolete files #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
PiperOrigin-RevId: 334645418 Source-Author: Google APIs <noreply@google.com> Source-Date: Wed Sep 30 11:43:23 2020 -0700 Source-Repo: googleapis/googleapis Source-Sha: c941026e5e3d600817a20e9ab4d4be03dff21a68 Source-Link: googleapis/googleapis@c941026
google-cla
bot
added
the
cla: yes
tswast
changed the title
tswast
reviewed
Oct 9, 2020
| @@ -89,7 +89,7 @@ class StandardSqlField(proto.Message): | |||
|
|
|||
| name = proto.Field(proto.STRING, number=1) | |||
|
|
|||
| type = proto.Field(proto.MESSAGE, number=2, message=StandardSqlDataType,) | |||
There was a problem hiding this comment.
This is a breaking change, but it's not a very commonly used interface (just for people who would be using the BQ Storage API directly)
There was a problem hiding this comment.
Actually, BQ Storage API reports schema in native serialization format (Avro / Arrow). This is a breaking change for folks that are introspecting the types of their BQML models.
tswast
reviewed
Oct 9, 2020
| @@ -33,5 +40,86 @@ | |||
| "generator": "bazel" | |||
| } | |||
| } | |||
| ], | |||
| "generatedFiles": [ | |||
There was a problem hiding this comment.
Not 100% sure what this does, but it was called "tracking obsolete files" here: googleapis/python-cloud-core#43
tswast
approved these changes
Oct 9, 2020
tswast
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Synth log will be available here:
https://source.cloud.google.com/results/invocations/4563ab42-f1d6-4a7f-8e48-cc92dfba56b5/targets
PiperOrigin-RevId: 334645418
Source-Link: googleapis/googleapis@c941026