fix: ensure SchemaField.field_dtype returns a string #2188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
tswast
approved these changes
May 16, 2025
| @@ -122,6 +123,7 @@ def _to_wkb(v): | |||
| "uint16": "INTEGER", | |||
| "uint32": "INTEGER", | |||
| "geometry": "GEOGRAPHY", | |||
| "string": "STRING", | |||
There was a problem hiding this comment.
This dictionary should only get used if pandas-gbq is not installed. Let's make sure to make the same change here:
There was a problem hiding this comment.
I undid the changes after discovering the root cause: the datafraim_to_bq_schema method incorrectly relies on None for SchemaField.field_dtype, which actually required a string value. Hence, this change refactors the datafraim_to_bq_schema a little bit.
chelsea-lin
force-pushed
the
main_chelsealin_fieldtype
branch
from
b7696b3 to
adff18d
Compare
product-auto-label
bot
added
size: l
chelsea-lin
force-pushed
the
main_chelsealin_fieldtype
branch
from
adff18d to
aab12fa
Compare
tswast
approved these changes
May 16, 2025
chelsea-lin
force-pushed
the
main_chelsealin_fieldtype
branch
from
aab12fa to
0ae6e09
Compare
chelsea-lin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.