Content-Length: 318008 | pFad | https://github.com/googleapis/python-aiplatform/commit/b9b373b69eab7dd303816bad94da54cad60a331e

7F feat: Remove deletion of model upload staging bucket in system tests · googleapis/python-aiplatform@b9b373b · GitHub
Skip to content

Commit b9b373b

Browse files
matthew29tangcopybara-github
authored andcommitted
feat: Remove deletion of model upload staging bucket in system tests
PiperOrigin-RevId: 602531376
1 parent b2458ec commit b9b373b

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

tests/system/aiplatform/test_model_upload.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
_XGBOOST_MODEL_URI = "gs://cloud-samples-data-us-central1/vertex-ai/google-cloud-aiplatform-ci-artifacts/models/iris_xgboost/model.bst"
2929

3030

31-
@pytest.mark.usefixtures("delete_staging_bucket", "tear_down_resources")
31+
@pytest.mark.usefixtures("tear_down_resources")
3232
class TestModelUploadAndUpdate(e2e_base.TestEndToEnd):
3333

3434
_temp_prefix = "temp_vertex_sdk_e2e_model_upload_test"
@@ -59,8 +59,6 @@ def test_upload_and_deploy_xgboost_model(self, shared_state):
5959
# Checking that the bucket is auto-generated
6060
assert "-vertex-staging-" in staging_bucket.name
6161

62-
shared_state["bucket"] = staging_bucket
63-
6462
# Currently we need to explicitly specify machine type.
6563
# See https://github.com/googleapis/python-aiplatform/issues/773
6664
endpoint = model.deploy(machine_type="n1-standard-2")

tests/system/aiplatform/test_model_version_management.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from tests.system.aiplatform import test_model_upload
2929

3030

31-
@pytest.mark.usefixtures("delete_staging_bucket", "tear_down_resources")
31+
@pytest.mark.usefixtures("tear_down_resources")
3232
class TestVersionManagement(e2e_base.TestEndToEnd):
3333

3434
_temp_prefix = "temp_vertex_sdk_e2e_model_upload_test"
@@ -66,8 +66,6 @@ def test_upload_deploy_manage_versioned_model(self, shared_state):
6666
# Checking that the bucket is auto-generated
6767
assert "-vertex-staging-" in staging_bucket.name
6868

69-
shared_state["bucket"] = staging_bucket
70-
7169
assert model.version_description == version_description
7270
assert model.version_aliases == version_aliases
7371
assert "default" in model.version_aliases

0 commit comments

Comments
 (0)








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/python-aiplatform/commit/b9b373b69eab7dd303816bad94da54cad60a331e

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy