fix: Use Spanner's UPSERT over INSERT #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-INSERT use cases in Spanner when the primary key stays the same. Otherwise the DELETE is not pushed before INSERT and the client gets a 409 Row [abc] already exists. The way LangChain integration is designed, there is no easy way to wrap them all in a TX with additional args for such visibility.
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
the
api: spanner
|
/gcbrun |
averikitsch
approved these changes
Sep 20, 2024
averikitsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to UPSERT. This provides for a nice experience for DELETE-then-INSERT use cases in Spanner when the primary key stays the same. Otherwise the DELETE is not pushed before INSERT and the client gets a 409 Row [abc] already exists. The way LangChain integration is designed, there is no easy way to wrap them all in a TX with additional args for such visibility.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕