-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add MySQLVectorStore initialization methods #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Need to swap test instance over to instance that has MySQL vector support enabled. |
ignore_metadata_columns: Optional[List[str]] = None, | ||
id_column: str = "langchain_id", | ||
metadata_json_column: Optional[str] = "langchain_metadata", | ||
index_query_options: Optional[QueryOptions] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to name it "query_options" instead of index_query_options. In PG QueryOptions is a sub attribute of index, though in Mysql it will be separate. There will be something more than than the index itself such as whether to use KNN query or ANN query, which we call "search_type"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we want to update to query_options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is updated to query_options
, this comment is pinned on out of date code
ignore_metadata_columns: Optional[List[str]] = None, | ||
id_column: str = "langchain_id", | ||
metadata_json_column: Optional[str] = "langchain_metadata", | ||
index_query_options: Optional[QueryOptions] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we want to update to query_options?
Adding
MySQLVectorStore
and all the different class methods to initialize it.Example usage: