feat: Add document saver class and support save/load/delete user journey #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: cloudsql-mysql
averikitsch
previously requested changes
Feb 6, 2024
4 tasks
kurtisvg
requested changes
Feb 8, 2024
Comment on lines
127
to
136
| # Get field type information | ||
| column_types = [ | ||
| cast(tuple, field)[0:2] for field in result_proxy.cursor.description | ||
| ] |
There was a problem hiding this comment.
Can we put a more illustrative comment on what this means?
I don't know whats in result_proxy.cursor.description, or why we are casting it to a tuple and slicing (I'm assuming it's maybe col_name / col_type but it would be good to clarify what's happening).
There was a problem hiding this comment.
Sure added comment that explains cursor.description.
The definition of cursor.description can be found here:
https://peps.python.org/pep-0249/#description
We need cast it to tuple here otherwise mypy will complain
error: Value of type "DBAPIType" is not indexable
|
@kurtisvg @averikitsch Code is ready for another round of review now. |
kurtisvg
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add document saver class and support save/load/delete user journeys.
In detail: