Content-Length: 277713 | pFad | https://github.com/googleapis/java-aiplatform/pull/185

EB chore: replaced hard-coded values with env vars by munkhuushmgl · Pull Request #185 · googleapis/java-aiplatform · GitHub
Skip to content
This repository was archived by the owner on Sep 9, 2023. It is now read-only.

chore: replaced hard-coded values with env vars #185

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

munkhuushmgl
Copy link
Contributor

Fixes #6 ☕️

@munkhuushmgl munkhuushmgl requested a review from a team March 1, 2021 20:37
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Mar 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2021
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #185 (8e0137b) into master (ea1afeb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage     78.06%   78.06%           
  Complexity     1402     1402           
=========================================
  Files            97       97           
  Lines         10158    10158           
  Branches        137      137           
=========================================
  Hits           7930     7930           
  Misses         2051     2051           
  Partials        177      177           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea1afeb...8fdbdaa. Read the comment docs.

@munkhuushmgl
Copy link
Contributor Author

@telpirion Can you update these hard coded vals with corresponding & matching env var strings ?

private static final String DATASET_ID = "1084241610289446912";
private static final String MODEL_ID = "4992732768149438464";
private static final String ENDPOINT_ID = "4366591682456584192";
private static final String MODEL_ID = "3422489426196955136";
private static final String MODEL_ID = "3512561418744365056";
private static final String EVALUATION_ID = "9035588644970168320";
private static final String SLICE_ID = "6481571820677004173";

@stephaniewang526
Copy link

Great! Thank you :)

@telpirion telpirion merged commit 3ce7268 into master Mar 3, 2021
@telpirion telpirion deleted the enable_env_vars branch March 3, 2021 17:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing env vars for samples' tests
3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/java-aiplatform/pull/185

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy