Get the code to compile with Microsoft Visual Studio 2017. #178

coryan · 2018-01-12T15:27:57Z

These changes fix the compilation problems on Windows (actually tested with MSVC 2017, but should, work with others), they unblock @paprat so he can continue working on #23. They also fix #100.

Incidentally this fixes googleapis#100. Lots of warnings in Abseil and Protobuf code that I am chosing not to silence.

I forgot that we had an embedded grpc::Status() which does not have noexcept moves.

paprat · 2018-01-12T16:39:13Z

bigtable/client/version.h

 #if __cplusplus < 201103L
 #error "Bigtable C++ Client requires C++11"
 #endif  // __cplusplus < 201103L
+#elif _MSC_VER < 1700


If I am not wrong default and delete functions are not supported by _MSC_VER 1700 according to this. And I think we need this feature.

Fixed. Check for 1900.

paprat

A minor comment.

@paprat

Thanks to @paprat for pointing out that key C++11 features are missing in MSVC 2013 (aka 17.00)

coryan · 2018-01-12T17:38:09Z

PTAL.

mbrukman · 2018-01-14T05:57:34Z

doc/setup-development-environment.md

+  automake \
+  build-essential \
+  clang \
+  ... # More stuff ommitted.


s/ommitted/omitted/

mbrukman · 2018-01-14T05:57:51Z

doc/setup-development-environment.md

+
+## Windows
+
+If you mainly use Windows as your development environment you need to install


s/environment you/environment, you/

mbrukman · 2018-01-14T05:58:35Z

doc/setup-development-environment.md

+in a `cmd.exe` shell, running as the `Administrator`:
+
+```commandline
+c:> @"%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe" -NoProfile -ExecutionPolicy Bypass -Command "iex (


Use C:\> as the prompt?

mbrukman · 2018-01-14T05:59:46Z

doc/setup-development-environment.md

+
+### Creating a Windows VM using Google Compute Engine
+
+If you do not have a Windows workstation but need a Windows development


s/workstation but/workstation, but/

mbrukman · 2018-01-14T05:59:57Z

doc/setup-development-environment.md

+### Creating a Windows VM using Google Compute Engine
+
+If you do not have a Windows workstation but need a Windows development
+environment to troubleshoot a test or build problem it might be convenient to


s/problem it/problem, it/

mbrukman · 2018-01-14T06:01:53Z

doc/setup-development-environment.md

+The previous installation should create a
+`Developer Command Prompt for VS 2017` entry in your "Windows" menu, use that
+entry to create a new shell.
+In that shell install `vcpkg` the Microsoft supported ports for many Open Source


s/shell install/shell, install/

mbrukman · 2018-01-14T06:02:24Z

doc/setup-development-environment.md

+The previous installation should create a
+`Developer Command Prompt for VS 2017` entry in your "Windows" menu, use that
+entry to create a new shell.
+In that shell install `vcpkg` the Microsoft supported ports for many Open Source


[...] vcpkg, the Microsoft-supported [...]

mbrukman · 2018-01-14T06:03:45Z

doc/setup-development-environment.md

+## Windows
+
+If you mainly use Windows as your development environment you need to install
+a number of tools.  We use [chocolatey](https://www.chocolatey.com) to drive the


s/chocolatey/Chocolatey/

mbrukman · 2018-01-14T06:06:08Z

doc/setup-development-environment.md

+
+Then you can install the dependencies in the same shell:
+```commandline
+c:> choco install -y cmake git cmake.portable activeperl ninja golang yasm putty


we should probably upper-case the prompt as it's typically C: not c:

the prompt is typically C:\> but I see you're probably not including the path, because it changes (you have some cd commands below — I typically pattern-match on C:\> so it was a bit confusing to see c:> as the prompt, as I don't think I've ever seen that version in my use of Windows or DOS

do you want to use C:\...> as the prompt to avoid updating the path? Or maybe just >?

I am going with option 3.

mbrukman · 2018-01-14T06:07:09Z

doc/setup-development-environment.md

+c:> puttygen
+```
+
+Then store the key in your [GitHub Settings](https://github.com/settings/keys),


There are two steps in this one line, so they should be split up into separate sentences for clarity.

And we can [skip ci] for this.

mbrukman

LGTM

We can [skip ci] for this.

rameshdharan · 2018-01-18T10:44:04Z

bigtable/client/client_options_test.cc

@@ -14,6 +14,15 @@

 #include "bigtable/client/client_options.h"

+#include <cstdlib>
+#ifdef WIN32


Here and elsewhere - _WIN32 is preferable (leading underscore variant) versus WIN32.

rameshdharan · 2018-01-18T10:50:28Z

doc/setup-development-environment.md

+using your favorite RDP client.  For example the
+[chrome extension](https://chrome.google.com/webstore/detail/chrome-rdp-for-google-clo/mpbbnannobiobpnfblimoapbephgifkm/)
+
+### Connecting to GitHub with PuTTY


FWIW Windows 10 ships a real OpenSSH client (and server) now. I suspect that will rather quickly become a dominant SSH client for Windows developers.

coryan added 3 commits January 12, 2018 13:56

Get the code to compile on Windows.

af0312c

Incidentally this fixes googleapis#100. Lots of warnings in Abseil and Protobuf code that I am chosing not to silence.

Reformat with clang-format.

490c835

Fixed noexcept in move operations.

54b5394

I forgot that we had an embedded grpc::Status() which does not have noexcept moves.

coryan assigned paprat Jan 12, 2018

coryan requested review from mbrukman and paprat January 12, 2018 15:27

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2018

paprat reviewed Jan 12, 2018

View reviewed changes

coryan added 2 commits January 12, 2018 12:35

Document how to setup a Windows workstation.

99ea3bc

Require MSVC 2015 or better.

3bcf310

Thanks to @paprat for pointing out that key C++11 features are missing in MSVC 2013 (aka 17.00)

mbrukman suggested changes Jan 14, 2018

View reviewed changes

coryan added 2 commits January 14, 2018 09:32

Address comments from review.

169aa9f

Address some more comments I missed.

c6cbcad

And we can [skip ci] for this.

mbrukman approved these changes Jan 15, 2018

View reviewed changes

Fixed typo.

50f9653

We can [skip ci] for this.

coryan merged commit ceae0a8 into googleapis:master Jan 15, 2018

coryan deleted the compile-on-windows branch January 15, 2018 16:28

rameshdharan reviewed Jan 18, 2018

View reviewed changes

JustinBeckwith unassigned paprat Jan 29, 2019


		## Windows

		If you mainly use Windows as your development environment you need to install


		### Creating a Windows VM using Google Compute Engine

		If you do not have a Windows workstation but need a Windows development

Get the code to compile with Microsoft Visual Studio 2017. #178

Get the code to compile with Microsoft Visual Studio 2017. #178

Uh oh!

Conversation

coryan commented Jan 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paprat left a comment

Choose a reason for hiding this comment

Uh oh!

coryan commented Jan 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbrukman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!