Content-Length: 273298 | pFad | https://github.com/googleapis/google-cloud-cpp/pull/13709

F0 refactor: split `MockRequestIdServiceStub` by coryan · Pull Request #13709 · googleapis/google-cloud-cpp · GitHub
Skip to content

refactor: split MockRequestIdServiceStub #13709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 1, 2024

Part of the work for #13704


This change is Reviewable

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.24%. Comparing base (af29661) to head (b29e1aa).

Files Patch % Lines
...tor/integration_tests/tests/mock_request_id_stub.h 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13709      +/-   ##
==========================================
- Coverage   93.25%   93.24%   -0.01%     
==========================================
  Files        2227     2228       +1     
  Lines      192995   192995              
==========================================
- Hits       179976   179964      -12     
- Misses      13019    13031      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review March 1, 2024 14:57
@coryan coryan requested a review from a team as a code owner March 1, 2024 14:57
@coryan coryan merged commit eb5abba into googleapis:main Mar 1, 2024
@coryan coryan deleted the refactor-generator-split-request-id-mock branch March 1, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/google-cloud-cpp/pull/13709

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy