Content-Length: 432664 | pFad | https://github.com/googleapis/google-api-python-client/pull/852

65 chore: use nox and release-please; drop 3.4 by busunkim96 · Pull Request #852 · googleapis/google-api-python-client · GitHub
Skip to content

chore: use nox and release-please; drop 3.4 #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 20, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 25, 2020

  • Replaces tox with nox
  • Allows release-please releases

I attempted to make as few changes as possible with the tox -> nox transition. The lint rules are the existing standards and are different from other libraries.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2020
@busunkim96 busunkim96 changed the title fix: drop 3.4 and add 3.8; use nox and release-please fix: use nox and release-please Mar 26, 2020
@busunkim96 busunkim96 changed the title fix: use nox and release-please chore: drop 3.4 and add 3.8; use nox and release-please Mar 26, 2020
@busunkim96 busunkim96 changed the title chore: drop 3.4 and add 3.8; use nox and release-please chore: use nox and release-please Mar 26, 2020
@busunkim96 busunkim96 requested review from crwilcox and plamut March 26, 2020 00:09
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I just have a few questions/nits.

Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my limited knowledge, the changes look good to me 👍 (although I cannot approve with 100% confidence).

Copy link
Contributor

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small problem:
#852 (comment)

Once it is fixed, it will be ok.

Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
@crwilcox
Copy link
Contributor

crwilcox commented Apr 7, 2020

Currently 3.4 tests are failing. We could drop it at this point, or fix what appears to be an encoding issue with code coverage tooling.

@busunkim96 busunkim96 changed the title chore: use nox and release-please chore: use nox and release-please; drop 3.4 Apr 20, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2020
@busunkim96 busunkim96 merged commit f706cfd into googleapis:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/googleapis/google-api-python-client/pull/852

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy