-
Notifications
You must be signed in to change notification settings - Fork 2.5k
chore: use nox and release-please; drop 3.4 #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
33157a5
to
63a6f98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, I just have a few questions/nits.
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
…ython-client into update-lib-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my limited knowledge, the changes look good to me 👍 (although I cannot approve with 100% confidence).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a small problem:
#852 (comment)
Once it is fixed, it will be ok.
Co-Authored-By: Kamil Breguła <mik-laj@users.noreply.github.com>
Currently 3.4 tests are failing. We could drop it at this point, or fix what appears to be an encoding issue with code coverage tooling. |
…ython-client into update-lib-tools
I attempted to make as few changes as possible with the tox -> nox transition. The lint rules are the existing standards and are different from other libraries.