Switch to upstream Lucas-C/pre-commit-hooks
#51440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
changed the title
Lucas-C/pre-commit-hooks
|
I think you should merge it with above repo |
|
@potiuk sorry dont follow you |
|
The upstream fix was meged, this is switching off my fork to a pinned commit on the upstream repo -- needs to be a commit, not a tag as it's not yet tagged. |
ashb
approved these changes
Jun 5, 2025
There are now two entries for the same repo:
They should be merged into one. |
|
Ah ok, didnt realise that. Let me do that |
amoghrajesh
force-pushed
the
remove-local-fork-ci
branch
from
735aceb to
157a1d5
Compare
|
@potiuk is it OK now? |
kaxil
reviewed
Jun 6, 2025
kaxil
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucas-C/pre-commit-hooks@fd3fbe8 was stopping us from using the upstream pre-commit-hooks in our precommit. Its merged now, so switching to the upstream library instead of private fork: https://github.com/Lucas-C/pre-commit-hooks
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.