Content-Length: 293900 | pFad | https://github.com/apache/airflow/pull/50418

B8 Helm Chart: Add gitConfig option for gitSync and upgrade NOTES.txt for Airflow v3 by mvfc · Pull Request #50418 · apache/airflow · GitHub
Skip to content

Helm Chart: Add gitConfig option for gitSync and upgrade NOTES.txt for Airflow v3 #50418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mvfc
Copy link
Contributor

@mvfc mvfc commented May 9, 2025


Add gitConfig Option to Airflow Helm Chart for Custom Git Configuration

This pull request introduces the following changes:

  1. gitConfig Parameter:

    • Added a new parameter, gitConfig, to the Apache Airflow Helm chart. This allows users to specify custom Git configuration settings for the git-sync sidecar container, offering more flexibility in managing Git behavior during DAG synchronization.
  2. Airflow API Server Update:

    • Updated the NOTES.txt to reflect the usage of .apiServer instead of .web for Airflow v3 deployments, aligning with the updated configuration style for Airflow v3 and improving compatibility with newer versions of the platform.

🔧 Changes Introduced

  • New Configuration Field:

    • dags.gitSync.gitConfig: Accepts a list of Git configuration entries, enabling users to set custom Git configurations such as user identity, credential helpers, and other Git settings.
  • Airflow Web to API Server Update:

    • Modified NOTES.txt to replace .web with .apiServer, which is the correct configuration for Airflow v3, ensuring the Helm chart is aligned with the latest Airflow version.

This addition aligns with the existing git-sync capabilities and allows for more tailored Git interactions within Airflow deployments.

🧪 Testing and Validation

  • Verified that custom Git configurations specified via gitConfig are correctly applied within the git-sync container.
  • Ensured that the addition of gitConfig does not interfere with existing git-sync functionality or other Helm chart configurations.
  • Confirmed that the .apiServer setting is correctly used in Airflow v3 and does not affect backward compatibility with Airflow v2.

📚 Documentation

  • Updated the Helm chart documentation to include the new gitConfig parameter, with examples demonstrating its usage.
  • Adjusted NOTES.txt to reflect the .apiServer setting for Airflow v3 deployments, ensuring correct configuration for Airflow v3 clusters.

🔄 Backward Compatibility

This change is backward compatible. If gitConfig is not specified, the git-sync container will operate with its default Git configuration.

  • The change from .web to .apiServer in notes.txt is only relevant for Airflow v3 deployments and does not affect Airflow v2.

📌 Related Issues

This enhancement addresses the need for more customizable Git configurations within the Airflow Helm chart's git-sync setup so it is possible to use all git providers, including Azure DevOps Repos.


By introducing the gitConfig parameter, this update provides users with enhanced control over Git behavior in their Airflow deployments, facilitating more complex and customized workflows.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label May 9, 2025
@mvfc mvfc force-pushed the upgrade_helm_chart branch 2 times, most recently from f1b4e2c to 7e38e27 Compare May 12, 2025 09:51
@mvfc mvfc changed the title Add gitConfig Option to Helm Chart and replace web with apiServer Helm Chart: Add gitConfig option for gitSync and upgrade NOTES.txt for Airflow v3 May 12, 2025
@mvfc mvfc marked this pull request as ready for review May 12, 2025 09:52
@mvfc mvfc force-pushed the upgrade_helm_chart branch 3 times, most recently from 5ca4d92 to 7296dbc Compare May 12, 2025 10:19
@mvfc
Copy link
Contributor Author

mvfc commented May 12, 2025

Not draft anymore, all tests passed locally, everything building normally locally

also deployed to my Azure Kubernetes Service (AKS) cluster and working just fine

@mvfc mvfc force-pushed the upgrade_helm_chart branch 14 times, most recently from 0777d7f to 3430e35 Compare May 14, 2025 22:07
@mvfc mvfc force-pushed the upgrade_helm_chart branch from 3430e35 to 5ca9088 Compare May 16, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/apache/airflow/pull/50418

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy