Content-Length: 331673 | pFad | https://github.com/apache/airflow/pull/25185

6C Fix MsSqlHook get_uri, adding pymssql driver to scheme (25092) by FanatoniQ · Pull Request #25185 · apache/airflow · GitHub
Skip to content

Fix MsSqlHook get_uri, adding pymssql driver to scheme (25092) #25185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fix MsSqlHook get_uri, adding pymssql driver to scheme (25092) #25185

merged 1 commit into from
Aug 5, 2022
+156 −2

Conversation

FanatoniQ
Copy link
Contributor

Fixes #25092

This PR fixes get_uri missing driver mention.
The missing driver in the uri resulted in broken get_sqlalchemy_engine due to odbc being the default for mssql.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

eladkal
eladkal reviewed Jul 20, 2022
View reviewed changes
@FanatoniQ FanatoniQ mentioned this pull request Jul 21, 2022
Closed
2 tasks
eladkal
eladkal reviewed Jul 21, 2022
View reviewed changes
@FanatoniQ FanatoniQ force-pushed the 25092-provider-mssql-get-sqlalchemy-engine branch from 8d4409d to 3dceee1 Compare July 21, 2022 14:02
@FanatoniQ FanatoniQ force-pushed the 25092-provider-mssql-get-sqlalchemy-engine branch 2 times, most recently from 54f1c93 to ea45cf4 Compare July 30, 2022 10:09
@FanatoniQ FanatoniQ requested a review from eladkal August 1, 2022 12:38
@FanatoniQ FanatoniQ force-pushed the 25092-provider-mssql-get-sqlalchemy-engine branch from f7d219c to a476c0e Compare August 1, 2022 17:18
@FanatoniQ FanatoniQ changed the title 25092: MsSqlHook: fix for get_uri, adding pymssql driver to scheme Fix MsSqlHook get_uri, adding pymssql driver to scheme (25092) Aug 1, 2022
@FanatoniQ FanatoniQ force-pushed the 25092-provider-mssql-get-sqlalchemy-engine branch from a476c0e to fcce9c5 Compare August 3, 2022 16:11
@FanatoniQ FanatoniQ force-pushed the 25092-provider-mssql-get-sqlalchemy-engine branch from fcce9c5 to 9907a76 Compare August 3, 2022 17:08
potiuk
potiuk approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @eladkal ?

@potiuk potiuk merged commit df5a54d into apache:main Aug 5, 2022
@ultrabug
Copy link
Contributor

ultrabug commented Aug 8, 2022

Congratulations @FanatoniQ ! and thanks @potiuk

This was referenced Aug 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@eladkal eladkal Awaiting requested review from eladkal

Assignees
No one assigned
Labels
area:providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MsSqlHook.get_sqlalchemy_engine uses pyodbc instead of pymssql
4 participants
@FanatoniQ @ultrabug @potiuk @eladkal








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/apache/airflow/pull/25185

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy