Content-Length: 307156 | pFad | https://github.com/apache/airflow/pull/16005

FB Check synctatic correctness for code-snippets by mik-laj · Pull Request #16005 · apache/airflow · GitHub
Skip to content

Check synctatic correctness for code-snippets #16005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2021
Merged

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented May 23, 2021

Some code snippets, although marked as Python code, were not valid Python code. I add blacken-docs to detect such snippets.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@mik-laj mik-laj requested review from potiuk and kaxil May 23, 2021 03:45
@boring-cyborg boring-cyborg bot added area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:providers kind:documentation provider:Apache provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues labels May 23, 2021
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj mik-laj changed the title Check syctatic correctness for code-snippets Check synctatic correctness for code-snippets May 24, 2021
@mik-laj
Copy link
Member Author

mik-laj commented May 26, 2021

@potiuk Can you look at iit?

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 26, 2021
@mik-laj mik-laj merged commit 904709d into apache:master May 27, 2021
@eladkal eladkal mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:dev-tools area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:amazon AWS/Amazon - related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/apache/airflow/pull/16005

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy